Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Double slash issue for download link #7194

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #7189

Tests | QA Steps

  1. Open app on Web
  2. Navigate to Settings > About > App download links > MacOS
  3. Install the app
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

I feel screenshots are not needed.

@parasharrajat parasharrajat requested a review from a team as a code owner January 13, 2022 01:02
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team January 13, 2022 01:05
@parasharrajat
Copy link
Member Author

@thienlnam This needs to be CP staging.

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@Jag96 Jag96 merged commit 58e180b into Expensify:main Jan 13, 2022
OSBotify pushed a commit that referenced this pull request Jan 13, 2022
fix: Double slash issue for download link
(cherry picked from commit 58e180b)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants