-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slash in Debit card expiration #7362
Merged
Julesssss
merged 27 commits into
Expensify:main
from
mananjadhav:fix/autoslash-expiration-date
Apr 13, 2022
Merged
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
91b17fa
fix: Added instance var and insertStringAt utils
mananjadhav 42b9524
fix: Added onKeyPress and onChangeText for slash handling
mananjadhav e584b66
Merge branch 'main' of https://github.com/mananjadhav/App into fix/au…
mananjadhav 5d29dd7
fix: Changed the auto slash logic for length
mananjadhav f334014
Merge branch 'main' of https://github.com/mananjadhav/App into fix/au…
mananjadhav 61b79ee
feat: moved the auto slash code to separate functions
mananjadhav c547151
fix: added funcs to this
mananjadhav a84ede9
fix: handle delete slash when its the last char
mananjadhav 77fd124
fix: Code cleanup
mananjadhav b1177c1
fix: added comment to functions
mananjadhav e0c7020
fix: change event to e.nativeEvent
mananjadhav d8b345f
Merge branch 'main' of https://github.com/mananjadhav/App into fix/au…
mananjadhav 578ec9e
fix: changed setstate to clearErrorAndSetValue, temp console added
mananjadhav eee0bed
Merge branch 'main' of https://github.com/mananjadhav/App into fix/au…
mananjadhav 88d83b4
fix: length check to > 2 for expirationdate
mananjadhav b51bb24
fix: removed keyup handling and update addslash function
mananjadhav 0c45288
fix: update binding and remove console log
mananjadhav 3ca97a1
fix: updated comment
mananjadhav b00729a
Merge branch 'main' of https://github.com/mananjadhav/App into fix/au…
mananjadhav eba7a98
fix: updated auto-slash logic to onChangeText
mananjadhav a5b8a5b
fix: removed unwanted var
mananjadhav 80bdec7
fix: comment alignment fixed
mananjadhav b9069d5
Merge branch 'main' of https://github.com/mananjadhav/App into fix/au…
mananjadhav bfb9491
Merge branch 'main' of https://github.com/mananjadhav/App into fix/au…
mananjadhav 6beb3d8
fix: remove unwanted variable
mananjadhav 0b3ed72
Merge branch 'main' of https://github.com/mananjadhav/App into fix/au…
mananjadhav 49956d7
refactor: changed comment language
mananjadhav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you just reword this sightly? It took me a couple of times to understand it properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated. Let me know if it is fine.