-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[P2P Statements] Add Wallet Statements Page + Modal #7663
Conversation
Just to put down where we are with progress right now, I discovered that the original plan of using After chatting briefly with @thienlnam, we said that an acceptable solution would be to use our current |
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
Need to add screenshots + QA steps then this PR is ready to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far, a few comments
It would also be good to add testing steps for web and mobile web to just visit http://localhost:8080/statements/202201 |
Followed the test steps and working fine on web: But on Android I'm getting this error: And this message in the logs:
Not sure if missing something for Android 🤔 |
Oh I didn't see this message, maybe that's why I'm getting the error on Android |
@marcochavezf This looks related to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked to Nick about this 1:1 but this also isn't being used yet so we can test the configuration stuff on staging. Although it would be good to make sure this works in the future on dev so other developers can test it
Will open up a PR for this! |
Triggered auto assignment to @deetergp ( |
@marcochavezf looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
Hmm this is weird, the tests already passed, I'm going to remove the |
Another one of these, yeah should not be a problem |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
That's weird. Why was I auto-assigned (not assigned as a reviewer) to a pull request? Especially one that was merged already?! |
🚀 Deployed to staging by @marcochavezf in version: 1.1.40-0 🚀
|
@deetergp I believe you were auto-assigned as the QA-er since this PR is marked as internal QA. However, I think we'd actually need to test this on Prod and not Staging. |
🚀 Deployed to production by @yuwenmemon in version: 1.1.40-2 🚀
|
Details
Add a new community package
react-native-webview
to render the Wallet Statements page in-app on mobile. For web/desktop, have the new Wallet Statements page open link to oldDot.Fixed Issues
$ GH_LINK
Tests
npm i
to install the node_module.sudo systemctl restart nginx
IOU_BILL
onSelected
property inSidebarScreen.js
so that we can test navigating to the statements page by clicking onSplit Bill
from the global menu.Split Bill
, verify you are taken to theStatements
page rendering in a new modal.QA Steps
web
for right now and would need to use an account that has wallet transactions, feel free to ping me and I can test on my end.Tested On
Screenshots
Web
Desktop
iOS
Android