Demote alert to info #7747
Merged
Demote alert to info #7747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
PauloGasparSv
and removed request for
a team
|
The idea was that it should get our attention when there are 10 retries with no success IMO If the client connection is so poor that the request is not reaching the backend after 10 retries (there's at least 1 sec. between each) the Network state should be set as |
PauloGasparSv
approved these changes
Feb 14, 2022
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
85 tasks
|
🚀 Deployed to staging by @PauloGasparSv in version: 1.1.39-0 🚀
|
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kidroca FYI since you added this log line (or at least blame showed your name)
Details
Context https://expensify.slack.com/archives/C0BS1NT42/p1644845508895869
This alert is when client does not have good connection, we can't do anything about this, so it should not be an alert
Fixed Issues
$ GH_LINK
Tests
None, just a log line change.
QA Steps
None
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android