Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: back arrow for drawer navigation when browser is resized #7801

Merged
merged 9 commits into from
Mar 7, 2022

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Feb 17, 2022

Details

#7091 (comment)

Fixed Issues

$ #7091

Tests | QA Steps

  1. Open the app on a web browser.
  2. open any chat.
  3. resize the browser to mobile view.
  4. Click the back arrow to open the LHN.

Note: Test this PR with #8067.

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

screen-2022-03-05_06.22.22.mp4

Mobile Web

screen-2022-03-06_13.34.11.mp4

Desktop

screen-2022-03-06_13.27.57.mp4

iOS

screen-2022-03-06_13.20.18.mp4
screen-2022-02-23_01.19.17.mp4

Android

screen-2022-03-06_12.01.23.mp4

@parasharrajat parasharrajat marked this pull request as ready for review March 6, 2022 08:05
@parasharrajat parasharrajat requested a review from a team as a code owner March 6, 2022 08:05
@botify botify requested a review from thienlnam March 6, 2022 08:05
@MelvinBot MelvinBot removed the request for review from a team March 6, 2022 08:05
@thienlnam thienlnam merged commit 5b42740 into Expensify:main Mar 7, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Mar 7, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @thienlnam in version: 1.1.42-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants