Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection drop is not detected #7825

Merged

Commits on Feb 19, 2022

  1. Delete libs/NetInfo - no longer needed

    libs/NetInfo served to provide shim for Electron due to an issue
    The issue is now resolved and this is no longer needed
    kidroca committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    1f19665 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d1181e2 View commit details
    Browse the repository at this point in the history
  3. Update NetInfo to v8

    Regarding the breaking change - we're not using SSID information - it doesn't affect us
    
    v8 Includes the following fixes:
    8.0.0 (2022-02-10)
    
    BREAKING CHANGES
    it's possible this is a breaking change, depending on your app use case. If you relied on iOS SSID information and met Apple's strict criteria for accessing SSID, you need to set the new config value shouldFetchWiFiSSID to true. If you set it to true and do not meet the criteria your app may crash due to a memory leak. All versions prior to 7.1.12 would attempt to fetch the information regardless of permission, leak memory, and possibly crash. This change avoids that crash.
    
    Bug Fixes
    ios: avoid memory leak from ssid APIs by adding explicit config (Expensify#560) (fbf7c15), closes Expensify#420
    
    7.1.11 (2022-02-08)
    Bug Fixes
    windows: fix race condition in WiFi connection details feature (Expensify#568) (0cd8132)
    
    7.1.10 (2022-02-07)
    Bug Fixes
    android: use registerDefaultNetworkCallback so toggling airplane mode works (Expensify#571) (e8af2de)
    
    7.1.9 (2022-01-26)
    Bug Fixes
    android: count native listeners / correctly disable listener if count == 0 (Expensify#569) (5ae16f6)
    
    7.1.8 (2022-01-25)
    Bug Fixes
    windows: refactor implementation to avoid crashes (Expensify#564) (cc4bfa3)
    
    7.1.7 (2021-12-20)
    Bug Fixes
    android: populate network value during initial module startup (Expensify#553) (c05080f)
    
    7.1.6 (2021-12-13)
    Bug Fixes
    android: avoid send event when has no listener (Expensify#548) (cad47d8)
    
    7.1.5 (2021-12-09)
    Bug Fixes
    android: use method-local ref to instance var for multi-thread safety Expensify#549 (Expensify#550) (81bbc87)
    
    7.1.4 (2021-12-07)
    Bug Fixes
    android: try async state fetch as stale state workaround (Expensify#547) (937cf48), closes Expensify#542
    kidroca committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    fc4a58c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3b52875 View commit details
    Browse the repository at this point in the history
  5. Use api url for internet checks

    This is primarily to help local development and desktop
    By default on web (desktop) the url for checking is `/`
    And for local testing you'll always hit it matching localhost:8080
    For Desktop since the app is served from electron - requesting `/`
    would respond with OK even if there's no internet
    kidroca committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    fa198f6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7ad9bc2 View commit details
    Browse the repository at this point in the history
  7. Faster offline detection

    kidroca committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    f5a0171 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Configuration menu
    Copy the full SHA
    924ef7b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2e9eb22 View commit details
    Browse the repository at this point in the history
  3. Add PR suggestion

    kidroca committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    8642da5 View commit details
    Browse the repository at this point in the history
  4. Remove trailing from recheck

    `trailing: false` causes duplicate calls
    removing it makes just one recheck request (as intended)
    kidroca committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    d9321c4 View commit details
    Browse the repository at this point in the history
  5. Fix typo

    kidroca committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    5cdc7ef View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Configuration menu
    Copy the full SHA
    cfec1cd View commit details
    Browse the repository at this point in the history
  2. Replace throttle logic with lock flag

    The recheck was getting triggered a lot even though there was a 10sec throttle
    Probably because throttle also uses setTimout
    kidroca committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    17c519e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1d3536a View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. Configuration menu
    Copy the full SHA
    b327db8 View commit details
    Browse the repository at this point in the history