-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix connection drop is not detected #7825
Merged
pecanoro
merged 16 commits into
Expensify:main
from
kidroca:kidroca/fix/connection-drop-is-not-detected
Mar 4, 2022
Merged
Fix connection drop is not detected #7825
pecanoro
merged 16 commits into
Expensify:main
from
kidroca:kidroca/fix/connection-drop-is-not-detected
Mar 4, 2022
Commits on Feb 19, 2022
-
Delete libs/NetInfo - no longer needed
libs/NetInfo served to provide shim for Electron due to an issue The issue is now resolved and this is no longer needed
Configuration menu - View commit details
-
Copy full SHA for 1f19665 - Browse repository at this point
Copy the full SHA 1f19665View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1181e2 - Browse repository at this point
Copy the full SHA d1181e2View commit details -
Regarding the breaking change - we're not using SSID information - it doesn't affect us v8 Includes the following fixes: 8.0.0 (2022-02-10) BREAKING CHANGES it's possible this is a breaking change, depending on your app use case. If you relied on iOS SSID information and met Apple's strict criteria for accessing SSID, you need to set the new config value shouldFetchWiFiSSID to true. If you set it to true and do not meet the criteria your app may crash due to a memory leak. All versions prior to 7.1.12 would attempt to fetch the information regardless of permission, leak memory, and possibly crash. This change avoids that crash. Bug Fixes ios: avoid memory leak from ssid APIs by adding explicit config (Expensify#560) (fbf7c15), closes Expensify#420 7.1.11 (2022-02-08) Bug Fixes windows: fix race condition in WiFi connection details feature (Expensify#568) (0cd8132) 7.1.10 (2022-02-07) Bug Fixes android: use registerDefaultNetworkCallback so toggling airplane mode works (Expensify#571) (e8af2de) 7.1.9 (2022-01-26) Bug Fixes android: count native listeners / correctly disable listener if count == 0 (Expensify#569) (5ae16f6) 7.1.8 (2022-01-25) Bug Fixes windows: refactor implementation to avoid crashes (Expensify#564) (cc4bfa3) 7.1.7 (2021-12-20) Bug Fixes android: populate network value during initial module startup (Expensify#553) (c05080f) 7.1.6 (2021-12-13) Bug Fixes android: avoid send event when has no listener (Expensify#548) (cad47d8) 7.1.5 (2021-12-09) Bug Fixes android: use method-local ref to instance var for multi-thread safety Expensify#549 (Expensify#550) (81bbc87) 7.1.4 (2021-12-07) Bug Fixes android: try async state fetch as stale state workaround (Expensify#547) (937cf48), closes Expensify#542
Configuration menu - View commit details
-
Copy full SHA for fc4a58c - Browse repository at this point
Copy the full SHA fc4a58cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b52875 - Browse repository at this point
Copy the full SHA 3b52875View commit details -
Use api url for internet checks
This is primarily to help local development and desktop By default on web (desktop) the url for checking is `/` And for local testing you'll always hit it matching localhost:8080 For Desktop since the app is served from electron - requesting `/` would respond with OK even if there's no internet
Configuration menu - View commit details
-
Copy full SHA for fa198f6 - Browse repository at this point
Copy the full SHA fa198f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ad9bc2 - Browse repository at this point
Copy the full SHA 7ad9bc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5a0171 - Browse repository at this point
Copy the full SHA f5a0171View commit details
Commits on Feb 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 924ef7b - Browse repository at this point
Copy the full SHA 924ef7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e9eb22 - Browse repository at this point
Copy the full SHA 2e9eb22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8642da5 - Browse repository at this point
Copy the full SHA 8642da5View commit details -
`trailing: false` causes duplicate calls removing it makes just one recheck request (as intended)
Configuration menu - View commit details
-
Copy full SHA for d9321c4 - Browse repository at this point
Copy the full SHA d9321c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cdc7ef - Browse repository at this point
Copy the full SHA 5cdc7efView commit details
Commits on Feb 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cfec1cd - Browse repository at this point
Copy the full SHA cfec1cdView commit details -
Replace throttle logic with lock flag
The recheck was getting triggered a lot even though there was a 10sec throttle Probably because throttle also uses setTimout
Configuration menu - View commit details
-
Copy full SHA for 17c519e - Browse repository at this point
Copy the full SHA 17c519eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d3536a - Browse repository at this point
Copy the full SHA 1d3536aView commit details
Commits on Feb 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b327db8 - Browse repository at this point
Copy the full SHA b327db8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.