Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: add image loading placeholder" #7933

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

mountiny
Copy link
Contributor

Reverts #7723

Coming from deploy blocker #7900

@mountiny mountiny requested a review from roryabraham February 28, 2022 15:10
@mountiny mountiny requested a review from a team as a code owner February 28, 2022 15:10
@mountiny mountiny self-assigned this Feb 28, 2022
@MelvinBot MelvinBot requested review from PauloGasparSv and removed request for a team February 28, 2022 15:10
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@mountiny
Copy link
Contributor Author

@roryabraham Coming from @kidroca investigation it seems the #7723 PR is causing the issues. I have created this Revert, feel free to review and merge to close the Deployblocker and @mdneyazahmad would then look into the feedback from @kidroca to fix the issue. It is not a required feature so we can revert and work on implementing it later and watch out for this problem.

@roryabraham
Copy link
Contributor

Okay, after some fiddling I was able to verify this fix locally.

@roryabraham roryabraham merged commit 88735de into main Feb 28, 2022
@roryabraham roryabraham deleted the revert-7723-feat/7584-image-placeholder branch February 28, 2022 20:18
OSBotify pushed a commit that referenced this pull request Feb 28, 2022
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.40-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 1, 2022

🚀 Deployed to production by @yuwenmemon in version: 1.1.40-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@SumitDiyora
Copy link

SumitDiyora commented Mar 21, 2022

Issue 1 -

Title- [Medium]: Chrome+ Jaws: Screen reader: Role is not defined for 'Send' control.
Actual - 'Actions (+)' control is not accessible using screen reader, while press Enter on the control focus moves to another control.
Note- On MAC screen reader is reading "Send Group".
Expected - Actions (+)' control should accessible using screen reader.
WCAG failure - 4.1.2
Reproducible in staging?: - Yes
Version Number: - v1.1.40-2
Platforms - Web, Desktop, Mobile-web, iOS, Android

#7933_Role not defined for Send control

Issue 2 -

Title- [Medium]: Chrome+ Jaws: Screen reader: Status message is not being announced by screen reader after activating the 'Send' control.
Actual - Status message is not being announced by screen reader after activating the 'Send' control. Screen reader is silent and focus lands on the Action (+) button.
Expected - Status message should announce by screen reader after uploading the attachment. Screen reader should read like "Image/video has been uploaded".
WCAG failure - 4.1.3
Reproducible in staging?: - Yes
Version Number: - v1.1.40-2
Platforms - Web, Desktop, Mobile-web, iOS, Android

7723_SCreen.reader.is.not.provide.the.information.after.sent.the.attachement.mp4

Issue 3 -

Title - [Medium] Chrome: Color Contrast: Insufficient color contrast for 'Create Room' control.
Actual - Background/foreground color combinations with an insufficient contrast ratio was found on control. For instance, the #03D47C "Send" control text has an insufficient color contrast ratio of 2.0.1 with a #FFFFFF background.
Expected - The "Send" text control should have a contrast ratio against the page background of 4.5:1 or greater..
WCAG failure - 1.4.3
Reproducible in staging?: - Yes
Version Number: - v1.1.42-2
Platforms - Web, Desktop, Mobile-web, iOS, Android
Suggested Fix - Ensure that each text/background color combination presents a contrast ratio of at least 4.5:1.

#7933_Color contrast fails for 'send' control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants