-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat: add image loading placeholder" #7933
Conversation
|
@roryabraham Coming from @kidroca investigation it seems the #7723 PR is causing the issues. I have created this Revert, feel free to review and merge to close the Deployblocker and @mdneyazahmad would then look into the feedback from @kidroca to fix the issue. It is not a required feature so we can revert and work on implementing it later and watch out for this problem. |
Okay, after some fiddling I was able to verify this fix locally. |
…laceholder (cherry picked from commit 88735de)
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.40-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @yuwenmemon in version: 1.1.40-2 🚀
|
Issue 1 - Title- [Medium]: Chrome+ Jaws: Screen reader: Role is not defined for 'Send' control. Issue 2 - Title- [Medium]: Chrome+ Jaws: Screen reader: Status message is not being announced by screen reader after activating the 'Send' control. 7723_SCreen.reader.is.not.provide.the.information.after.sent.the.attachement.mp4Issue 3 - Title - [Medium] Chrome: Color Contrast: Insufficient color contrast for 'Create Room' control. |
Reverts #7723
Coming from deploy blocker #7900