Add RadioButton components #8009
Conversation
src/components/RadioButtons.js
Outdated
|
|
||
| render() { | ||
| return ( | ||
| <view> |
There was a problem hiding this comment.
Missing import for this and also incorrect case. Surprise this did not error 🤔
|
Looks pretty good, but maybe we want just a little bit less space between the radio button and the text? I think we want something like 12px between them. |
|
Ok, changing the margin for checkbox labels too then. Before: After: |
|
Updated! |
src/styles/styles.js
Outdated
| borderRadius: 10, | ||
| height: 20, | ||
| width: 20, | ||
| borderColor: themeColors.border, |
There was a problem hiding this comment.
We've gotten feedback before that the border color for these feels way too light. Maybe that's a separate problem, but I could see bumping up the gray one step to using themeColors.icon which would make it a bit darker. Could I see a before/after on that so we can take a look? Thanks!
|
Updated! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @marcaaron in version: 1.1.42-0 🚀
|
|
🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀
|
|
I am tagging this PR to highlight an issue fixed here. All conditions in ternary expressions or left-hand operands on conditional renders, should be boolean. This PR is one of the PRs that uses conditional render with string operands, hence I am tagging it here for the contributors to check. We've also updated the item in the checklist with this PR to avoid this issue in the future. |
Fixed Issues
Needed by #7813 (comment)
Tests
Tested in #7813 (comment)
PR Review Checklist
None
Screenshots
Web