remove extra margin below checkbox #8017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
luacmartins and
parasharrajat
and removed request for
a team
parasharrajat
suggested changes
Mar 5, 2022
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
parasharrajat
previously approved these changes
Mar 5, 2022
There was a problem hiding this comment.
LGTM.
cc: @luacmartins
PR Reviewer Checklist
- I verified the Author pulled
mainbefore submitting the PR - I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the testing environment is mentioned in the test steps
- I verified testing steps cover success & fail scenarios (if applicable)
- I verified tests pass on all platforms & I tested again on all platforms
- I checked that screenshots or videos are included for tests on all platforms
- I verified there are no console errors related to changes in this PR
- I verified proper code patterns were followed (see Reviewing the code)
- I verified comments were added when the code was not self explanatory
- I verified any copy / text shown in the product was added in all
src/languages/*files (if applicable) - I verified proper naming convention for platform-specific files was followed (if applicable)
- I verified style guidelines were followed
- I verified that this PR follows the guidelines as stated in the Review Guidelines
🎀 👀 🎀 C+ reviewed
luacmartins
reviewed
Mar 7, 2022
| @@ -300,7 +300,7 @@ class BankAccountStep extends React.Component { | |||
| errorText={this.getErrorText('accountNumber')} | |||
| /> | |||
| <CheckboxWithLabel | |||
| style={[styles.mb4, styles.mt5]} | |||
| style={styles.mt5} | |||
There was a problem hiding this comment.
Let's update this to mt4 so they are all consistent.
luacmartins
approved these changes
Mar 8, 2022
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @luacmartins in version: 1.1.42-0 🚀
|
|
🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀
|
This was referenced Apr 7, 2022
Closed
Closed
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Remove the extra margin below the checkbox in
BankAccountStep,AddDebitCardPageandTermsSteppageFixed Issues
$ #7838
Tests
PR Review Checklist
Contributor (PR Author) Checklist
main### Fixed Issuessection abovesrc/languages/*files (if applicable)Styling.md) for all style edits I madeSTYLE.md)Avatar, I verified the components usingAvatarare working as expected)mainbranch)PR Reviewer Checklist
main### Fixed Issuessection abovesrc/languages/*files (if applicable)STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)mainbranch)QA Steps
For
Add a debit cardpage:Savebutton without checking the terms checkboxFor
Connect bank accountpage:Save & continuebutton without checking the terms checkboxFor
Terms and feespage:/settings/payments/enable-paymentsurlEnable paymentsbutton without checking the terms checkboxesScreenshots
Web
Mobile Web
Desktop
iOS
Android