Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert PR 8013, which introduced a bug #8054

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Revert PR 8013, which introduced a bug #8054

merged 1 commit into from
Mar 9, 2022

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Mar 9, 2022 •
edited
Loading

Details

Reverts a PR which was accidentally cherry-picked. See this Slack thread for much more details: https://expensify.slack.com/archives/C03TQ48KC/p1646832274218809

IT IS EXPECTED THAT THE ROOM AVATAR DOES NOT DISPLAY! This PR simply reverts the breaking changes.

Fixed Issues

$ #8040

Tests

  • Verify that no errors appear in the JS console

Test that the issue is fixed

  • Go to staging.new.expensify.com
  • Log in with exensifail account
  • Tap on FAB menu
  • Tap New Room
  • Put any room name and select Workspace
  • Tab Continue
  • Tap on Room name on top of the app
  • You should not see the full screen error page

PR Review Checklist

Contributor (PR Author) Checklist

  • I verified the PR has a small number of commits behind main
  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I clearly indicated the environment tests should be run in (Staging vs Production)
  • I wrote testing steps that cover success & fail scenarios (if applicable)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests & veryfy they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I followed proper code patterns (see Reviewing the code)
    • I added comments when the code was not self explanatory
    • I put all copy / text shown in the product in all src/languages/* files (if applicable)
    • I followed proper naming convention for platform-specific files (if applicable)
    • I followed style guidelines (in Styling.md) for all style edits I made
    • I followed the JSDocs style guidelines (in STYLE.md)
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I corroborated the UI performance was not affected (the performance is the same than main branch)
  • If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

  • I verified the PR has a small number of commits behind main
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the testing environment is mentioned in the test steps
  • I verified testing steps cover success & fail scenarios (if applicable)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified comments were added when the code was not self explanatory
    • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
    • I verified proper naming convention for platform-specific files was followed (if applicable)
    • I verified style guidelines were followed
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified the UI performance was not affected (the performance is the same than main branch)
  • If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

  • Verify that no errors appear in the JS console

@Julesssss Julesssss requested a review from TomatoToaster March 9, 2022 16:26
@Julesssss Julesssss requested a review from a team as a code owner March 9, 2022 16:26
@Julesssss Julesssss self-assigned this Mar 9, 2022
@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team March 9, 2022 16:26
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@TomatoToaster TomatoToaster merged commit e3c33ed into main Mar 9, 2022
@TomatoToaster TomatoToaster deleted the jules-revertCherryPickWithRegression branch March 9, 2022 16:37
OSBotify pushed a commit that referenced this pull request Mar 9, 2022
@OSBotify
Merge pull request #8054 from Expensify/jules-revertCherryPickWithReg…
960107a 
…ression

Revert PR 8013, which introduced a bug

(cherry picked from commit e3c33ed)
This was referenced Mar 9, 2022
Merged
Closed
@Julesssss Julesssss mentioned this pull request Mar 9, 2022
Merged
@OSBotify
Copy link
Contributor

OSBotify commented Mar 9, 2022

🚀 Cherry-picked to staging by @TomatoToaster in version: 1.1.41-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Mar 11, 2022
Closed
@Julesssss Julesssss mentioned this pull request Mar 11, 2022
Closed
@SumitDiyora SumitDiyora mentioned this pull request Apr 20, 2022
Closed
22 tasks
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomatoToaster TomatoToaster TomatoToaster approved these changes

@marcochavezf marcochavezf Awaiting requested review from marcochavezf

Assignees

@Julesssss Julesssss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Julesssss @OSBotify @TomatoToaster