Reapply RoomHeaderAvatars Logic to fix regression correctly this time

[TomatoToaster]

CC: @Julesssss

Details

Fixes regression found here , but this time
HOLD on #7852 being on staging.
context is here: https://expensify.slack.com/archives/C03TQ48KC/p1646832274218809
but this was deployed to staging before the original PR was deployed to staging so it broke the ReportDetails page. This will reintroduce the correct changes but requires that first PR to be deployed to staging first. Then this can be cherry picked.

Fixed Issues

related to #8040

Tests

N/A same as Web QA.

• Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

• I verified the PR has a small number of commits behind main
• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I clearly indicated the environment tests should be run in (Staging vs Production)
• I wrote testing steps that cover success & fail scenarios (if applicable)
• I included screenshots or videos for tests on all platforms
• I ran the tests & veryfy they passed on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors related to changes in this PR
• I followed proper code patterns (see Reviewing the code)
  • I added comments when the code was not self explanatory
  • I put all copy / text shown in the product in all src/languages/* files (if applicable)
  • I followed proper naming convention for platform-specific files (if applicable)
  • I followed style guidelines (in Styling.md) for all style edits I made
  • I followed the JSDocs style guidelines (in STYLE.md)
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I corroborated the UI performance was not affected (the performance is the same than main branch)
• If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

• I verified the PR has a small number of commits behind main
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the testing environment is mentioned in the test steps
• I verified testing steps cover success & fail scenarios (if applicable)
• I checked that screenshots or videos are included for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors related to changes in this PR
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified comments were added when the code was not self explanatory
  • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
  • I verified proper naming convention for platform-specific files was followed (if applicable)
  • I verified style guidelines were followed
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified the UI performance was not affected (the performance is the same than main branch)
• If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

This will be done on staging.
Find a defaultRoom, policyRoom, or workspaceChat and verify that when you click on the header and see the report details, it looks like this:

and not this:

• Verify that no errors appear in the JS console

Screenshots

N/A

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[danieldoglas]

LGTM

[Julesssss]

Thanks!

[danieldoglas]

@TomatoToaster is there a reason this is still on hold?

[TomatoToaster]

Nope! We can merge this now, I realized the other one just went to staging last night, but also we could've just merged this without the CP-staging label and it would fix it 😅

[OSBotify]

🚀 Cherry-picked to staging by @TomatoToaster in version: 1.1.42-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[OSBotify]

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅