Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Disable recheck against local web API when local web API is in use #8105

Merged
merged 1 commit into from
Mar 11, 2022
Merged

[No QA] Disable recheck against local web API when local web API is in use #8105

merged 1 commit into from
Mar 11, 2022

Conversation

marcaaron
Copy link
Contributor

Details

We are still having issues on dev related to #7825

Tests

  1. Setup ngrok
  2. Run web app
  3. Verify that we are not seeing infinite loops of going offline/online and ngrok tunnel does not crash

@marcaaron marcaaron requested a review from a team as a code owner March 11, 2022 20:54
@marcaaron marcaaron self-assigned this Mar 11, 2022
@MelvinBot MelvinBot requested review from aldo-expensify and removed request for a team March 11, 2022 20:55
luacmartins
luacmartins approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this!

@luacmartins luacmartins merged commit f916215 into main Mar 11, 2022
@luacmartins luacmartins deleted the marcaaron-disableRecheckOnDev branch March 11, 2022 21:01
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 15, 2022
Closed
52 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.43-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@SumitDiyora SumitDiyora mentioned this pull request Apr 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins approved these changes

@aldo-expensify aldo-expensify Awaiting requested review from aldo-expensify

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcaaron @OSBotify @luacmartins