-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove emoji picker menu for medium screen width tablets #8111
remove emoji picker menu for medium screen width tablets #8111
Conversation
PR is up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Merging now as it was a regression found in production. However, it is not a severe problem so I don't see any advantage in CP Staging, therefore let's just have this PR go through the normal deployment process.
@thesahindia Can you confirm in the QA steps, whether it should show in portrait or landscape mode? will the emoji be hidden for portrait too? (it does not have to, but can)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
It won't show up in landscape but if the screen is big enough that the LHN is visible in portrait mode then it also won't show up in portrait mode. |
🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀
|
@mountiny @rushatgabhane
Details
Fixed the regression caused by #7851
Fixed Issues
$ #7585
Tests/QA
PR Review Checklist
Contributor (PR Author) Checklist
main
### Fixed Issues
section abovesrc/languages/*
files (if applicable)Styling.md
) for all style edits I madeSTYLE.md
)Avatar
, I verified the components usingAvatar
are working as expected)main
branch)PR Reviewer Checklist
main
### Fixed Issues
section abovesrc/languages/*
files (if applicable)STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)main
branch)Screenshots
Web
Mobile Web
Desktop
iOS
Android