Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove emoji picker menu for medium screen width tablets #8111

Merged
merged 1 commit into from
Mar 13, 2022
Merged

remove emoji picker menu for medium screen width tablets #8111

merged 1 commit into from
Mar 13, 2022

Conversation

thesahindia
Copy link
Member

@thesahindia thesahindia commented Mar 12, 2022

@mountiny @rushatgabhane

Details

Fixed the regression caused by #7851

Fixed Issues

$ #7585

Tests/QA

  1. Open app on Tablet
  2. Navigate to any chat
  3. Verify no emoji picker option is there in landscape mode ( also in portrait mode for big screen tablets where LHN is visible )
  • Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

  • I verified the PR has a small number of commits behind main
  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I clearly indicated the environment tests should be run in (Staging vs Production)
  • I wrote testing steps that cover success & fail scenarios (if applicable)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests & veryfy they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I followed proper code patterns (see Reviewing the code)
    • I added comments when the code was not self explanatory
    • I put all copy / text shown in the product in all src/languages/* files (if applicable)
    • I followed proper naming convention for platform-specific files (if applicable)
    • I followed style guidelines (in Styling.md) for all style edits I made
    • I followed the JSDocs style guidelines (in STYLE.md)
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I corroborated the UI performance was not affected (the performance is the same than main branch)
  • If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

  • I verified the PR has a small number of commits behind main
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the testing environment is mentioned in the test steps
  • I verified testing steps cover success & fail scenarios (if applicable)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR/
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified comments were added when the code was not self explanatory
    • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
    • I verified proper naming convention for platform-specific files was followed (if applicable)
    • I verified style guidelines were followed
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified the UI performance was not affected (the performance is the same than main branch)
  • If a new component is created I verified that a similar component doesn't exist in the codebase

Screenshots

Web

Screenshot 2022-03-12 at 12 34 37 PM

Mobile Web

Screenshot 2022-03-12 at 12 39 23 PM

Desktop

Screenshot 2022-03-12 at 12 27 54 PM

iOS

Screenshot 2022-03-12 at 11 59 43 AM

Android

Screenshot 2022-03-12 at 12 39 23 PM

@thesahindia thesahindia requested a review from a team as a code owner March 12, 2022 07:23
@MelvinBot MelvinBot requested review from bondydaa and removed request for a team March 12, 2022 07:23
@thesahindia
Copy link
Member Author

PR is up
cc: @mountiny @rushatgabhane

@thesahindia
Copy link
Member Author

@bondydaa, sorry for the ping, please ignore it as @mountiny will be reviewing this.

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging now as it was a regression found in production. However, it is not a severe problem so I don't see any advantage in CP Staging, therefore let's just have this PR go through the normal deployment process.

@thesahindia Can you confirm in the QA steps, whether it should show in portrait or landscape mode? will the emoji be hidden for portrait too? (it does not have to, but can)

@mountiny mountiny merged commit 6a3759b into Expensify:main Mar 13, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@thesahindia
Copy link
Member Author

@thesahindia Can you confirm in the QA steps, whether it should show in portrait or landscape mode? will the emoji be hidden for portrait too? (it does not have to, but can)

It won't show up in landscape but if the screen is big enough that the LHN is visible in portrait mode then it also won't show up in portrait mode.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @mountiny in version: 1.1.43-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants