Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isReportMessageAttachment logic #8117

Merged
merged 6 commits into from
Apr 5, 2022
Merged

Update isReportMessageAttachment logic #8117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2f04f13
Update isReportMessageAttachment logic
sobitneupane Mar 13, 2022
6ac4f2d
Pass single param to isReportMessageAttachment
sobitneupane Mar 17, 2022
375a9bb
Change isReportMessageAttachment argument
sobitneupane Mar 18, 2022
c8d47c9
Change defaultValue of reportAction in message
sobitneupane Mar 18, 2022
eb91d95
Change comment of isReportMessageAttachment function
sobitneupane Mar 18, 2022
fc3c0bb
Destructure isReportMessageAttachment parameter
sobitneupane Apr 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/OptionsListUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ function createOption(personalDetailList, report, {
: {};

const lastActorDetails = report ? _.find(personalDetailList, {login: report.lastActorEmail}) : null;
const lastMessageTextFromReport = ReportUtils.isReportMessageAttachment(lodashGet(report, 'lastMessageText', ''))
const lastMessageTextFromReport = ReportUtils.isReportMessageAttachment(lodashGet(report, 'lastMessageText', ''), lodashGet(report, 'lastMessageHtml', ''))
? `[${Localize.translateLocal('common.attachment')}]`
: Str.htmlDecode(lodashGet(report, 'lastMessageText', ''));
let lastMessageText = report && hasMultipleParticipants && lastActorDetails
Expand Down
3 changes: 2 additions & 1 deletion src/libs/actions/Report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ function getSimplifiedReportObject(report) {
oldPolicyName,
visibility,
isOwnPolicyExpenseChat: lodashGet(report, ['isOwnPolicyExpenseChat'], false),
lastMessageHtml: lastActionMessage,
};
}

Expand Down Expand Up @@ -628,7 +629,7 @@ function updateReportWithNewAction(
// Add the action into Onyx
reportActionsToMerge[reportAction.sequenceNumber] = {
...reportAction,
isAttachment: ReportUtils.isReportMessageAttachment(messageText),
isAttachment: ReportUtils.isReportMessageAttachment(messageText, lodashGet(reportAction, ['message', 0, 'html'], '')),
loading: false,
};

Expand Down
7 changes: 4 additions & 3 deletions src/libs/reportUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ function getReportParticipantsTitle(logins) {
* Check whether a report action is Attachment is not.
*
* @param {Object} reportMessageText report action's message as text
* @param {Object} reportMessageHtml report action's message as html
* @returns {Boolean}
*/
function isReportMessageAttachment(reportMessageText) {
return reportMessageText === '[Attachment]';
function isReportMessageAttachment(reportMessageText, reportMessageHtml) {
return reportMessageText === '[Attachment]' && reportMessageHtml !== '[Attachment]';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could put the lodashGet in here rather than passing it in as an argument.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Sorry @parasharrajat, didn't see this before leaving this comment 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries.

}

/**
Expand Down Expand Up @@ -60,7 +61,7 @@ function canEditReportAction(reportAction) {
return reportAction.actorEmail === sessionEmail
&& reportAction.reportActionID
&& reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT
&& !isReportMessageAttachment(lodashGet(reportAction, ['message', 0, 'text'], ''));
&& !isReportMessageAttachment(lodashGet(reportAction, ['message', 0, 'text'], ''), lodashGet(reportAction, ['message', 0, 'html'], ''));
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/pages/home/report/ContextMenu/ContextMenuActions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export default [

const isAttachment = _.has(reportAction, 'isAttachment')
? reportAction.isAttachment
: ReportUtils.isReportMessageAttachment(text);
: ReportUtils.isReportMessageAttachment(text, html);
if (!isAttachment) {
Clipboard.setString(text);
} else {
Expand Down