Don't show chatrooms as a Contact if you are the only participant

[TomatoToaster]

@neil-marcellini, please review when you get the chance
CC: @marcaaron, @marcochavezf, @Julesssss

Details

Found out that we are showing workspace chats as contacts that you can send money to, start a chat with, or split a bill with. This should not be the case.

Fixed Issues

Related to https://github.com/Expensify/Expensify/issues/195471

Tests

Similar to QA except done locally.

• Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

• I verified the PR has a small number of commits behind main
• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I clearly indicated the environment tests should be run in (Staging vs Production)
• I wrote testing steps that cover success & fail scenarios (if applicable)
• I included screenshots or videos for tests on all platforms
• I ran the tests & veryfy they passed on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors related to changes in this PR
• I followed proper code patterns (see Reviewing the code)
  • I added comments when the code was not self explanatory
  • I put all copy / text shown in the product in all src/languages/* files (if applicable)
  • I followed proper naming convention for platform-specific files (if applicable)
  • I followed style guidelines (in Styling.md) for all style edits I made
  • I followed the JSDocs style guidelines (in STYLE.md)
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I corroborated the UI performance was not affected (the performance is the same than main branch)
• If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

• I verified the PR has a small number of commits behind main
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the testing environment is mentioned in the test steps
• I verified testing steps cover success & fail scenarios (if applicable)
• I checked that screenshots or videos are included for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors related to changes in this PR
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified comments were added when the code was not self explanatory
  • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
  • I verified proper naming convention for platform-specific files was followed (if applicable)
  • I verified style guidelines were followed
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified the UI performance was not affected (the performance is the same than main branch)
• If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

This should be tested on staging.new.expensify.com on an account that has access to the workspace chat beta (applause and expensifail account should work)

1. Log into an admin account with a workspace chat. If you don't have one, create a worksapce and a workspace chat should be automatically generated for you. It will look like this:

2. Click on global create and try to create a New Chat. It should NOT show your workspace chat as one of the options. Verify you do NOT see the following. If you do then this QA had failed:

3. Next try to request money and, like above, after entering the amount verify you do NOT see this:

4. Do the same with split bill.

• Verify that no errors appear in the JS console

Screenshots

N/A

[marcochavezf]

👍🏽

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @TomatoToaster in version: 1.1.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅