Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix avatars in search screen to invite new members #8143

Merged
merged 1 commit into from
Mar 14, 2022
Merged

fix avatars in search screen to invite new members #8143

merged 1 commit into from
Mar 14, 2022

Conversation

marcochavezf
Copy link
Contributor

@marcochavezf marcochavezf commented Mar 14, 2022 •
edited
Loading

Details

This PR fixes a missing edge case when Workspace chats were implemented cc @sketchydroide @francoisl @chiragsalian

Fixed Issues

$ #8092

Tests / QA

  1. Launch the app and log in with any account
  2. Go to Setting
  3. Tap on any Workspace you have in your account
  4. Go to Manage Members
  5. Tap the Invite button.
  6. The search screen should show the correct avatars instead of the default Profile icon:

Screen Shot 2022-03-14 at 12 53 53

  • Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

  • I verified the PR has a small number of commits behind main
  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I clearly indicated the environment tests should be run in (Staging vs Production)
  • I wrote testing steps that cover success & fail scenarios (if applicable)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests & veryfy they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I followed proper code patterns (see Reviewing the code)
    • I added comments when the code was not self explanatory
    • I put all copy / text shown in the product in all src/languages/* files (if applicable)
    • I followed proper naming convention for platform-specific files (if applicable)
    • I followed style guidelines (in Styling.md) for all style edits I made
    • I followed the JSDocs style guidelines (in STYLE.md)
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I corroborated the UI performance was not affected (the performance is the same than main branch)
  • If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

  • I verified the PR has a small number of commits behind main
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the testing environment is mentioned in the test steps
  • I verified testing steps cover success & fail scenarios (if applicable)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified comments were added when the code was not self explanatory
    • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
    • I verified proper naming convention for platform-specific files was followed (if applicable)
    • I verified style guidelines were followed
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified the UI performance was not affected (the performance is the same than main branch)
  • If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

  • Verify that no errors appear in the JS console

Screenshots

Web

Screen Shot 2022-03-14 at 13 10 20

Mobile Web

Android:
Screen Shot 2022-03-14 at 13 24 13

iOS:
Screen Shot 2022-03-14 at 13 32 31

Desktop

Screen Shot 2022-03-14 at 13 13 09

iOS

Screen Shot 2022-03-14 at 13 31 00

Android

Screen Shot 2022-03-14 at 13 17 06

@marcochavezf marcochavezf requested a review from a team as a code owner March 14, 2022 19:33
@marcochavezf marcochavezf self-assigned this Mar 14, 2022
@MelvinBot MelvinBot requested review from Justicea83 and removed request for a team March 14, 2022 19:33
francoisl
francoisl approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@francoisl francoisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally and works well 👍

@marcochavezf
Copy link
Contributor Author

Thanks @francoisl! I'm going to merge the PR since it fixes a deploy blocker

@marcochavezf marcochavezf merged commit e4cad4c into main Mar 14, 2022
@marcochavezf marcochavezf deleted the marco-fixInviteNewMemberAvatars branch March 14, 2022 20:51
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@chiragsalian
Copy link
Contributor

chiragsalian commented Mar 15, 2022 •
edited
Loading

Remember a deploy blocker PR should always be CP-d to staging by applying the CP-staging label before merging it. I'll work on manually CP-ing this now. SO

OSBotify pushed a commit that referenced this pull request Mar 15, 2022
@marcochavezf @OSBotify
Merge pull request #8143 from Expensify/marco-fixInviteNewMemberAvatars
a3dfc90 
fix avatars in search screen to invite new members

(cherry picked from commit e4cad4c)
@OSBotify OSBotify mentioned this pull request Mar 15, 2022
Merged
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @chiragsalian in version: 1.1.42-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Justicea83
Justicea83 reviewed Mar 15, 2022
View reviewed changes
Copy link
Contributor

@Justicea83 Justicea83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcochavezf
Copy link
Contributor Author

Remember a deploy blocker PR should always be CP-d to staging by applying the CP-staging label before merging it. I'll work on manually CP-ing this now. SO

Thanks for the heads-up, I will keep it on mind next time! 🙇🏾

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Mar 16, 2022
Closed
52 tasks
This was referenced Mar 31, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justicea83 Justicea83 Justicea83 left review comments

@francoisl francoisl francoisl approved these changes

Assignees

@marcochavezf marcochavezf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcochavezf @OSBotify @chiragsalian @francoisl @Justicea83