Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change SubscriptAvatar mode prop to size #8144

Merged
merged 7 commits into from
Mar 14, 2022
Merged

Conversation

marcochavezf
Copy link
Contributor

@marcochavezf marcochavezf commented Mar 14, 2022

Details

This is a pending change from Workspace chats implementation, also includes Storybooks stories for SubscriptAvatar component cc @roryabraham

Screen Shot 2022-03-14 at 14 07 05

Screen Shot 2022-03-14 at 14 07 23

Fixed Issues

This is a follow-up PR of #7852 (comment)

Tests / QA

Pre-requisites:

  • Create or use an existing account which will be the admin
  • Add the admin account to policyExpenseChat beta
  • Create a Workspace and invite a few workspace members.
  • As admin send a message to one of the members through the workspace chat

Steps:

  1. From the workspace chat mark a few messages as unread
  2. Enable #focus mode on Settings -> Preferences
  3. The SubscriptAvatar should be displayed in small size
  • Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

  • I verified the PR has a small number of commits behind main
  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I clearly indicated the environment tests should be run in (Staging vs Production)
  • I wrote testing steps that cover success & fail scenarios (if applicable)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests & veryfy they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I followed proper code patterns (see Reviewing the code)
    • I added comments when the code was not self explanatory
    • I put all copy / text shown in the product in all src/languages/* files (if applicable)
    • I followed proper naming convention for platform-specific files (if applicable)
    • I followed style guidelines (in Styling.md) for all style edits I made
    • I followed the JSDocs style guidelines (in STYLE.md)
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I corroborated the UI performance was not affected (the performance is the same than main branch)
  • If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

  • I verified the PR has a small number of commits behind main
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the testing environment is mentioned in the test steps
  • I verified testing steps cover success & fail scenarios (if applicable)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified comments were added when the code was not self explanatory
    • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
    • I verified proper naming convention for platform-specific files was followed (if applicable)
    • I verified style guidelines were followed
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified the UI performance was not affected (the performance is the same than main branch)
  • If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

  • Verify that no errors appear in the JS console

Screenshots

Web

Screen Shot 2022-03-14 at 13 53 28

Mobile Web

Screen Shot 2022-03-14 at 14 14 25

Screen Shot 2022-03-14 at 14 14 56

Desktop

Screen Shot 2022-03-14 at 14 06 29

iOS

Screen Shot 2022-03-14 at 14 20 10

Android

Screen Shot 2022-03-14 at 14 12 56

@marcochavezf marcochavezf requested a review from a team as a code owner March 14, 2022 20:20
@marcochavezf marcochavezf self-assigned this Mar 14, 2022
@MelvinBot MelvinBot requested review from amyevans and removed request for a team March 14, 2022 20:20
amyevans
amyevans previously approved these changes Mar 14, 2022
src/stories/SubscriptAvatar.stories.js Outdated Show resolved Hide resolved
@amyevans amyevans merged commit 95251f9 into main Mar 14, 2022
@amyevans amyevans deleted the marco-subscriptAvatarSize branch March 14, 2022 22:23
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor

roryabraham commented Mar 15, 2022

Thanks for the follow-up @marcochavezf !

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @amyevans in version: 1.1.43-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants