Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] update checklist for contributor and reviewer #8165

Merged
merged 1 commit into from
Mar 15, 2022
Merged

[No QA] update checklist for contributor and reviewer #8165

merged 1 commit into from
Mar 15, 2022

Conversation

marcochavezf
Copy link
Contributor

@marcochavezf marcochavezf commented Mar 15, 2022 •
edited
Loading

Details

Coming from this slack thread, this PR updates some of the checklist points that were not clear and includes a few more points.

Fixed Issues

N/A

Tests

N/A

QA Steps

N/A

Screenshots

N/A

@marcochavezf marcochavezf requested a review from a team as a code owner March 15, 2022 20:07
@marcochavezf marcochavezf self-assigned this Mar 15, 2022
@MelvinBot MelvinBot requested review from yuwenmemon and removed request for a team March 15, 2022 20:07
@marcochavezf marcochavezf changed the title update checklist for contributor and reviewer [No QA] update checklist for contributor and reviewer Mar 15, 2022
yuwenmemon
yuwenmemon approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@yuwenmemon yuwenmemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lotta steps!

@yuwenmemon yuwenmemon merged commit 3d705d0 into main Mar 15, 2022
@yuwenmemon yuwenmemon deleted the marco-updatePRChecklist branch March 15, 2022 20:22
@OSBotify OSBotify mentioned this pull request Mar 15, 2022
Closed
52 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @yuwenmemon in version: 1.1.43-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@SumitDiyora SumitDiyora mentioned this pull request Apr 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenmemon yuwenmemon yuwenmemon approved these changes

Assignees

@marcochavezf marcochavezf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcochavezf @OSBotify @yuwenmemon