-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle iframe/webview navigation in-app #8174
Conversation
Updated with message type! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @PauloGasparSv in version: 1.1.46-0 🚀
|
Triggered auto assignment to @AndrewGable ( |
This should be tested in prod! |
Details
We want to handle iframe navigation in NewDot. This PR makes the Statement page communicate events to its parent if it's being rendered as an iframe.
cc @thienlnam
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/200657
Tests
Before you start:
https://new.expensify.com
tolocalhost:8080
.a. Change this url to
https://www.expensify.com/statement.php?period=202112
b. Grab a production authToken for your account and hardcode it here
Steps
+ > Split bills
Request money
,Send money
,Split bill
.QA Steps
As of now, this can only be tested on Web.
/statement/202112
.PR Review Checklist
Contributor (PR Author) Checklist
main
### Fixed Issues
section abovesrc/languages/*
files (if applicable)Styling.md
) for all style edits I madeSTYLE.md
)Avatar
, I verified the components usingAvatar
are working as expected)main
branch)PR Reviewer Checklist
main
### Fixed Issues
section abovesrc/languages/*
files (if applicable)STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)main
branch)Screenshots
Web
web.mov
Mobile Web
I couldn't find a way to test this on mWeb because of the conflicting cross origin restrictions. Web needs to access local host, but the device itself blocks non-secure connections and thus needs the prod API.
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov