-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Press On Enter in Button with Dropdown #8206
Press On Enter in Button with Dropdown #8206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NikkiWines LGTM! 🎉
- I verified the correct issue is linked in the ### Fixed Issues section above
- I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I checked that screenshots or videos are included for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
- I verified there are no console errors related to changes in this PR
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. “toggleReport” and not “onIconClick”).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct english, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct english and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like
Avatar
, I verified the components usingAvatar
are working as expected) - I verified the UI performance was not affected (the performance is the same than
main
branch) - If a new component is created I verified that
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- Any internal methods are bound to “this” properly so there are no scoping issues
- Any internal methods bound to “this” are necessary to be bound
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
- If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function
- (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but @sobitneupane we need videos for iOS and Android and I think the QA steps should say "Press Enter/Return or "Go" on mobile keyboard" not just "Press enter" to account for the mobile flow.
i swear we had videos 😭 |
I have not included screenshots for native apps as pressing enter in native apps does not select the button as in web and desktop. Same is the case in Search Page, Profile Page, Request money confirmation page and so on. So, I thought it was the expected behaviour. |
@sobitneupane if you look at #7964 you can see that the issue is listed as occurring on all platforms and that there are specific steps provided for mobile keyboards. I would use those steps as a basis for what steps your PR needs and what platforms need to be tested. |
@NikkiWines I don't remember exactly, but we don't do that because If you think we could improve on this, please let me know. |
Ah ok, sorry for the misunderstanding! Then my only suggestion would be to update the QA steps so that they check/confirm that the behavior is working as intended (i.e. 'Confirm pressing enter routes you to the next step of the flow' instead of just saying 'press enter') |
🚀 Deployed to staging by @NikkiWines in version: 1.1.46-0 🚀
|
Details
Solves the issue "Enter/return doesn't work when the button has options". I have not included screenshots for native apps as pressing enter in native apps does not select the button as in web and desktop. We can verify that in Search Page, Profile Page, Request money confirmation page and so on.
Fixed Issues
$ #7964
Tests
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectionsrc/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
property(i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectionsrc/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
property(i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)QA Steps
Screenshots
Web
Screen.Recording.2022-03-17.at.21.43.36.mov
Mobile Web
Screen.Recording.2022-03-17.at.22.02.50.mov
Desktop
Screen.Recording.2022-03-17.at.21.49.45.mov
iOS
Android