Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] update PR checklist #8231

Merged
merged 1 commit into from
Mar 21, 2022
Merged

[No QA] update PR checklist #8231

merged 1 commit into from
Mar 21, 2022

Conversation

marcochavezf
Copy link
Contributor

@marcochavezf marcochavezf commented Mar 18, 2022

Details

This updates the PR checklist for both Contributors and Reviewers based on the recent changes to this doc.
slack convo

cc @aldo-expensify

Fixed Issues

N/A

Tests

N/A

QA Steps

N/A

Screenshots

N/A

@marcochavezf marcochavezf self-assigned this Mar 18, 2022
@marcochavezf marcochavezf requested a review from a team as a code owner March 18, 2022 22:34
@melvin-bot melvin-bot bot requested review from MariaHCD and removed request for a team March 18, 2022 22:35
@MariaHCD MariaHCD merged commit f5c49a0 into main Mar 21, 2022
@MariaHCD MariaHCD deleted the marco-updatePRChecklist branch March 21, 2022 11:22
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @MariaHCD in version: 1.1.46-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.46-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants