Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Feat] Add Image loading indicator" #8242

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

mountiny
Copy link
Contributor

Reverts #8203

Because of performance issue found in this comment.

I am rather reverting it now before having it in staging.

@mountiny mountiny self-assigned this Mar 20, 2022
@mountiny mountiny requested a review from a team as a code owner March 20, 2022 22:02
@melvin-bot melvin-bot bot requested review from deetergp and removed request for a team March 20, 2022 22:03
@nathanmetcalf nathanmetcalf self-requested a review March 20, 2022 22:09
@mountiny mountiny merged commit 6c037b9 into main Mar 20, 2022
@mountiny mountiny deleted the revert-8203-feat/7584-image-loading-indicator branch March 20, 2022 22:13
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @mountiny in version: 1.1.46-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.46-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants