Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused expensify-cash URL schema #8254

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

sketchydroide
Copy link
Contributor

@sketchydroide sketchydroide commented Mar 21, 2022

CC @Julesssss

Details

Remove unused expensify-cash URL schema

Fixed Issues

$https://github.com/Expensify/Expensify/issues/176081

Tests

N/A

PR Review Checklist

N/A

Screenshots

N/A

@sketchydroide sketchydroide requested a review from a team as a code owner March 21, 2022 13:13
@sketchydroide sketchydroide self-assigned this Mar 21, 2022
@melvin-bot melvin-bot bot requested review from PauloGasparSv and removed request for a team March 21, 2022 13:14
@sketchydroide sketchydroide changed the title Remove unused expensify-cash URL schema [WIP] Remove unused expensify-cash URL schema Mar 21, 2022
@sketchydroide sketchydroide changed the title [WIP] Remove unused expensify-cash URL schema Remove unused expensify-cash URL schema Mar 21, 2022
Copy link
Contributor

@PauloGasparSv PauloGasparSv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PauloGasparSv PauloGasparSv merged commit 0777861 into main Mar 21, 2022
@PauloGasparSv PauloGasparSv deleted the afonseca_remove_old_url_scheme branch March 21, 2022 14:44
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @PauloGasparSv in version: 1.1.46-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.46-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants