Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myself as a "code owner" for some files in need of review #8258

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

marcaaron
Copy link
Contributor

Details

Several areas of this codebase are performance sensitive and/or complex areas that require extra care. I would like to temporarily watch these areas for some time and help make sure C+ and our contributors are making the best decisions they can.

Fixed Issues

No Issue.

Tests

No QA

@marcaaron marcaaron requested a review from a team as a code owner March 21, 2022 19:16
@marcaaron marcaaron self-assigned this Mar 21, 2022
@melvin-bot melvin-bot bot requested review from nickmurray47 and removed request for a team March 21, 2022 19:17
Copy link
Contributor

@nickmurray47 nickmurray47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickmurray47 nickmurray47 merged commit 36ae0cf into main Mar 21, 2022
@nickmurray47 nickmurray47 deleted the marcaaron-codeOwnersProblemAreas branch March 21, 2022 19:25
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nickmurray47 in version: 1.1.46-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.46-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants