Add createOnReadyTask. Fix broken growls triggered before init.

[marcaaron]

Details

Sometimes Growls can be triggered before init.

Fixed Issues

Related to https://github.com/Expensify/Expensify/issues/201705

Tests

1. Place a call to Growl.success() in the constructor of Expensify.js

diff --git a/src/components/GrowlNotification/index.js b/src/components/GrowlNotification/index.js
index e3a16b600..b8d5855b7 100644
--- a/src/components/GrowlNotification/index.js
+++ b/src/components/GrowlNotification/index.js
@@ -12,6 +12,7 @@ import * as Expensicons from '../Icon/Expensicons';
 import styles from '../../styles/styles';
 import GrowlNotificationContainer from './GrowlNotificationContainer';
 import CONST from '../../CONST';
+import Growler from '../../libs/Growl';
 import * as Growl from '../../libs/Growl';

 const types = {
@@ -43,6 +44,8 @@ class GrowlNotification extends Component {

         this.show = this.show.bind(this);
         this.fling = this.fling.bind(this);
+
+        Growler.success('derpy derp pants');
     }

     componentDidMount() {

2. Verify it will run once the Growl component mounts

Only other specific QA we need to do here that I can think of is to test the ActiveClientManager logic to make sure it is still functioning as intended. I just logged out that this code executed:

App/src/libs/Network.js

Lines 272 to 276 in 9beba91

	// Post any pending request after we launch the app
	ActiveClientManager.isReady().then(() => {
	flushPersistedRequestsQueue();
	startDefaultQueue();
	});

• Verify that no errors appear in the JS console

QA Steps

Test offline report comments feature for regressions

1. Go offline
2. Add a comment
3. Close page
4. Come back online
5. Reopen New Expensify
6. Verify queued comments post to chat.

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[marcaaron]

Manually CP'ing this to staging.

[marcaaron]

Oh nvm I cannot because I'm not a mobile deployer haha

[OSBotify]

🚀 Cherry-picked to staging by @chiragsalian in version: 1.1.44-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.