-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make onfido page scrollable #8603
make onfido page scrollable #8603
Conversation
@thesahindia How did you pass the sign-in screen. I selected the chase account from the list and it takes me to the production website of chase |
You can try adding the bank account manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @AndrewGable in version: 1.1.56-0 🚀
|
🚀 Deployed to production by @francoisl in version: 1.1.56-0 🚀
|
Details
Made the onfido page scrollable.
Fixed Issues
$ #8128
Tests | QA Steps
Steps to test locally on web -
App/src/pages/ReimbursementAccount/RequestorStep.js
Lines 157 to 158 in fd0f83a
3. Now login with the same account in development build and navigate to connect bank account and press
continue with setup
you will see the onfido pagePR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Screenshots
Web
Screen.Recording.2022-04-12.at.4.25.39.PM.mov
Mobile Web
Screen.Recording.2022-04-12.at.4.21.58.PM.mov
Desktop
Screen.Recording.2022-04-12.at.4.31.09.PM.mov
iOS
Screen.Recording.2022-04-12.at.4.17.55.PM.mov
Android
Screen.Recording.2022-04-12.at.4.04.31.PM.mov