Code

[HOLD] Comment linking#8638

Code

Closed

chiragsalian wants to merge 120 commits intomainExpensify/App:mainfrom chirag-comment-linking-2Expensify/App:chirag-comment-linking-2Copy head branch name to clipboard

+238-25

Commits

Commits on Apr 13, 2022

• trying something

  chiragsalian

  committed
  88cf9a0

• Revert "trying something"

  Show description for c3cead4
  chiragsalian

  committed
  c3cead4

• trying scroll to index

  chiragsalian

  committed
  b9ba1a8

Commits on Apr 14, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  092cd54

Commits on Apr 19, 2022

• trying some stuff

  chiragsalian

  committed
  7f398e0

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  79dbeb5

Commits on Apr 20, 2022

• trying more things

  chiragsalian

  committed
  87f265a

• still trying

  chiragsalian

  committed
  7c33dce

Commits on Apr 21, 2022

• getting marcs changes over here

  chiragsalian

  committed
  dd112ea

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  44107a4

• getting shouldMeasureItems key back

  chiragsalian

  committed
  c555567

• Using measurementPadding prop to make the logic easier to understand

  chiragsalian

  committed
  5f54dec

• removing some test artifacts

  chiragsalian

  committed
  ffa360e

• Updating method name to make it more obvious what it does

  chiragsalian

  committed
  a726bf2

Commits on Apr 22, 2022

• Adding new route and screen

  chiragsalian

  committed
  acedf55

• updating maindrawernavigator to work with new screen

  chiragsalian

  committed
  0a34329

• passing reportActionID

  chiragsalian

  committed
  000e9e9

• loading more chats as needed and scrolling to them

  chiragsalian

  committed
  c0645ec

• renaming to const

  chiragsalian

  committed
  58e29ae

Commits on Apr 26, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  aa719a7

• passing isSelected to ReportActionItem for highlighting

  chiragsalian

  committed
  a91512c

Commits on Apr 27, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  1d8b816

• animate background

  chiragsalian

  committed
  768d182

• Add URL to clipboard

  chiragsalian

  committed
  e2515ef

• removing actionID from route

  chiragsalian

  committed
  44df461

• correcting clipboard URL

  chiragsalian

  committed
  284510c

Commits on Apr 28, 2022

• Have link open in same session

  chiragsalian

  committed
  406e0f3

Commits on Apr 29, 2022

• working code to have scroll work for actions in same report screen

  chiragsalian

  committed
  f0c237c

Commits on May 2, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  2c5f036

• updates to support the new ReportActionsList

  chiragsalian

  committed
  38fcacb

Commits on May 3, 2022

• remove debug

  chiragsalian

  committed
  e505a41

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  02971bf

Commits on May 4, 2022

• navigation test to have drawer closed on simulator

  chiragsalian

  committed
  fa0429e

• working code to scroll to rendered comments for mobile and web

  chiragsalian

  committed
  39636da

Commits on May 5, 2022

• background animation working better

  chiragsalian

  committed
  2dee013

• working animation when the comment is close to the bottom

  chiragsalian

  committed
  2f6b424

• cleanup and comments

  chiragsalian

  committed
  a6cbf5f

• BaseInvertedFlastList cleanup

  chiragsalian

  committed
  a36ba6a

• cleanup

  chiragsalian

  committed
  a38583a

• cleanup

  chiragsalian

  committed
  cf86da6

• cleanup

  chiragsalian

  committed
  74f3626

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  861c21d

Commits on May 18, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  c1e0e48

• support for getenv urls

  chiragsalian

  committed
  e7e8cac

• updating clipboard copy to have it work for any environment

  chiragsalian

  committed
  a1330c9

• cleanup

  chiragsalian

  committed
  98923cc

• cleanup

  chiragsalian

  committed
  0ec6319

• build dev url using dynamic port logic

  chiragsalian

  committed
  9ca9cf6

• fix for anchor rendered to work with any port

  chiragsalian

  committed
  e69b719

Commits on May 19, 2022

• anchor renderer fix

  chiragsalian

  committed
  6a3ef3a

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  386e98b

• cleanup

  chiragsalian

  committed
  44b686b

Commits on May 20, 2022

• trying some drawer stuff

  chiragsalian

  committed
  d56b71b

• trying some drawer stuff on ios

  chiragsalian

  committed
  bde0075

• trying to figure out dispatch flow

  chiragsalian

  committed
  24659d7

Commits on May 23, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  2a00456

Commits on May 24, 2022

• console logs

  chiragsalian

  committed
  1cfd18a

• more logs

  chiragsalian

  committed
  7c97f12

• closing drawer in report screen

  chiragsalian

  committed
  891cf0d

• removing test logs

  chiragsalian

  committed
  4c09166

• revert open drawer prop

  chiragsalian

  committed
  6e458a0

• cleanup

  chiragsalian

  committed
  4be820b

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  2b7deae

• updating background color

  chiragsalian

  committed
  993c0f1

Commits on May 25, 2022

• couple of bug fixes

  chiragsalian

  committed
  97ca234

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  3295c4e

• color update

  chiragsalian

  committed
  a01990b

• correct native measurement logic to fire early

  chiragsalian

  committed
  f0c9c92

• fixing autoscroll reset value since its set in constructor and preventing autoscroll on failed attempt

  chiragsalian

  committed
  e0816dd

• setting doneMeasurement when loading chats so thats its not incorrectly changed

  chiragsalian

  committed
  2beaa4e

• bug fixes and more comments

  chiragsalian

  committed
  7e54987

• removing debugging consoles

  chiragsalian

  committed
  756a9f7

Commits on May 26, 2022

• cleanups

  chiragsalian

  committed
  8ad706b

Commits on May 31, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  c478e6b

Commits on Jun 1, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  fa1829e

• move check for closeDrawer to componentDidUpdate

  chiragsalian

  committed
  719ec04

• getting radix back since its part of our lint

  chiragsalian

  committed
  ed8547a

• more readable params for ReportActionsView

  chiragsalian

  committed
  8fa2c4a

• more readable params for ReportActionsList

  chiragsalian

  committed
  88f7c2c

• more readable params for ReportActionItem

  chiragsalian

  committed
  95f794a

• minor bug fixes

  chiragsalian

  committed
  aca301c

Commits on Jun 2, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  6ad2271

• Update src/pages/home/report/ReportActionsView.js

  Show description for 68339fc
  

  chiragsalian

  and

  marcaaron

  authored
  68339fc

• cleanup

  chiragsalian

  committed
  9c7d1f8

• Merge branch 'chirag-comment-linking-2' of github.com:Expensify/App into chirag-comment-linking-2

  chiragsalian

  committed
  cadf4a7

• Update src/pages/home/report/ReportActionsView.js

  Show description for a616d92
  

  chiragsalian

  and

  marcaaron

  authored
  a616d92

Commits on Jun 10, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  3626a3b

Commits on Jun 14, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  aa57ca7

• remove artificial 3 attempt limit

  chiragsalian

  committed
  7dbc386

• fixes so that animation works on mount as well

  chiragsalian

  committed
  44b4d54

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  8aacd3e

Commits on Jun 21, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  7c329ab

• revert some changes since they are handled in another PR

  chiragsalian

  committed
  d3221f1

• revert line breaks and copy link feature

  chiragsalian

  committed
  c65848d

• removing unused lib

  chiragsalian

  committed
  a298497

• need dev const and internalNewExpensifyPath to recognize dev url

  chiragsalian

  committed
  aab906e

Commits on Jun 22, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  c6c5cac

Commits on Jun 23, 2022

• dev regex const

  chiragsalian

  committed
  0cb9829

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  1fff2ed

Commits on Jun 24, 2022

• moving animation to componentDidUpdate instead of render

  chiragsalian

  committed
  1150f3a

• rename and keeping string for reportActionID

  chiragsalian

  committed
  0fb83f6

• minor cleanup

  chiragsalian

  committed
  f2e0af8

Commits on Jun 25, 2022

• trying something different to simplify code

  chiragsalian

  committed
  f7415aa

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  3ed10b0

Commits on Jun 26, 2022

• cleanup

  chiragsalian

  committed
  115145f

• some more cleanups

  chiragsalian

  committed
  81b5a3e

Commits on Jun 27, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  80fca12

Commits on Jun 28, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  622269a

• testing navigation fixes

  chiragsalian

  committed
  7fed32c

• removing debug code

  chiragsalian

  committed
  7e799d1

Commits on Jun 29, 2022

• working code using linkTo

  chiragsalian

  committed
  1ebfefa

• Navigation fixes

  chiragsalian

  committed
  7816878

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  70633f1

Commits on Jun 30, 2022

• oops lint fix

  chiragsalian

  committed
  b42db8d

• minor revert and cleanup

  chiragsalian

  committed
  057396a

Commits on Jul 7, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  6369ba7

• comment linking beta

  chiragsalian

  committed
  4bd36a5

• allow comment linking to work only if user is part of beta

  chiragsalian

  committed
  8f2e11e

Commits on Jul 8, 2022

• Merge branch 'main' into chirag-comment-linking-2

  chiragsalian

  committed
  b0cf8a0

• Correct a test change

  chiragsalian

  committed
  cc67fb7