Removing focus style on blur - Web/Desktop #8765

LucioChavezFuentes · 2022-04-25T16:39:16Z

Details

Pickers onClose is not executed on Web and Desktop, so props.onClose has to be called with onBlur callback.

Fixed Issues

$ #7535 (especifaclly to this regression)

Tests

Web, Desktop, Android / Chrome

Go to Settings --> Preferences. (or any other page with Picker)
Select any Picker, a blue outline focus should appear around it .

( options should also appear, of course)

Close the menu options by choosing any element or click out of it.
Click another element or click outside of previoulsy selected Picker.
The blue outline focus of previoulsy selected Pickershould be removed.

iOS, Android, iOS / Safari

Same steps as previous, just make sure the focus style disappear as soon as the menu is closed.

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Same steps as Tests section.

Verify that no errors appear in the JS console

Screenshots

Web

Screen.Recording.2022-04-29.at.22.14.50.720.mov

Mobile Web / Safari

Screen.Recording.2022-04-29.at.23.10.48.mov

Desktop

Screen.Recording.2022-04-29.at.23.26.32.mov

iOS

Screen.Recording.2022-04-29.at.23.19.22.mov

Android

Screen.Recording.2022-04-29.at.23.32.50.mov

Android/ Chrome

Screen.Recording.2022-04-29.at.23.41.21.mov

melvin-bot · 2022-04-25T16:39:19Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

luacmartins

Tests well, but I wonder why can't we just standardize on onFocus and onBlur and rename those props in BasePicker?

LucioChavezFuentes · 2022-04-25T18:42:22Z

Tests well, but I wonder why can't we just standardize on onFocus and onBlur and rename those props in BasePicker?

Let me check the scope of these props on Picker component and see if can simplify.

LucioChavezFuentes · 2022-04-26T01:34:50Z

@luacmartins Picker's on onClose and onOpen are used only for native mobile. onFocus and onBlur are used for Web and Desktop. I made a refactor for onFocus and onBlur event so anyone using Picker could use these props independently of platform been developed.
Just think onFocus when you click or tap on Picker and onBlur when you select your option or simply exit with a click or tap out.
If you pass a callback onFocus or onPicker, not only they behave like they currently do (setting or removing the blue outline focus) but also execute the callback passed (like the Form's onBlur callback). Of course, if you pass nothing they just do their current behaviour.

What do you think?

luacmartins · 2022-04-26T15:42:44Z

@LucioChavezFuentes let's see what you got.

rushatgabhane · 2022-04-26T16:57:14Z

@stitesExpensify @luacmartins
Sorry for the mess I'd like to unassign myself because I'm really slacking off here. And I'm OOO

LucioChavezFuentes · 2022-04-26T22:05:19Z

@luacmartins I made my changes in this PR, take a look on my refactoring onFocus and onBlur .

luacmartins · 2022-04-27T16:48:48Z

@LucioChavezFuentes I didn't realize how much refactoring and how confusing standardizing on onFocus and onBlur would be when I suggested it. I think it's best to revert the changes from your last commit and go with the simpler approach here. Sorry about the extra work!

LucioChavezFuentes · 2022-04-27T17:52:40Z

No problem. Reverting...

This reverts commit 0dbb44d. Signed-off-by: LucioChavezFuentes <luciobertinchavez@gmail.com>

LucioChavezFuentes · 2022-04-27T18:36:29Z

PR updated. Ready to be reviewed.

luacmartins

LGTM! Thanks for the fix.

Santhosh-Sellavel · 2022-04-29T18:23:00Z

I'll check this today.

Santhosh-Sellavel · 2022-04-29T19:41:56Z

@LucioChavezFuentes

Can you update the PR Screenshots with videos performing the steps?

LucioChavezFuentes · 2022-04-29T20:17:51Z

Can you update the PR Screenshots with videos performing the steps?

Sure, give me a moment.

LucioChavezFuentes · 2022-04-29T22:02:02Z

@Santhosh-Sellavel PR updated with videos. You can review them now.

Santhosh-Sellavel · 2022-04-30T11:24:22Z

PR Reviewer Checklist

I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

Santhosh-Sellavel

Looks good, tests well!

@luacmartins,

The props onBlur, onClose, onFocus are not defined basePickerPropTypes.
Are we okay with this?

LucioChavezFuentes · 2022-05-05T21:49:43Z

PR updated and ready to reviewed, but I'm having a Lint problem, looks like someone is working on an urgent problem.

src/languages/en.js

src/languages/es.js

LucioChavezFuentes · 2022-05-09T15:34:06Z

PR updated and ready to be reviewed. No more lint problems.

luacmartins

LGTM and tests well! Thanks for the fix! All yours @Santhosh-Sellavel and @stitesExpensify!

stitesExpensify

Looks good! Just one question

src/components/Picker/BasePicker/index.js

Santhosh-Sellavel · 2022-05-12T16:44:07Z

Will review this today.

Santhosh-Sellavel · 2022-05-12T19:39:40Z

@luacmartins Are the new copies verified by the marketing team?

luacmartins · 2022-05-12T21:03:33Z

Are the new copies verified by the marketing team?

I don't believe so. However, I think this should be ok given that they are in line with our other messages. @stitesExpensify what do you think?

stitesExpensify · 2022-05-12T22:13:53Z

If it was copied from previously approved copy then I think it's fine

parasharrajat · 2022-05-16T16:17:04Z

Any update on this PR? This PR also resolves #9015

stitesExpensify

LGTM. All you @luacmartins @Santhosh-Sellavel

luacmartins

LGTM and tests well! Thanks for the fix!

luacmartins · 2022-05-16T18:13:52Z

Seems like all concerns have been addressed. Merging...

OSBotify · 2022-05-16T19:42:16Z

🚀 Deployed to staging by @luacmartins in version: 1.1.61-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-05-17T16:59:06Z

🚀 Deployed to production by @AndrewGable in version: 1.1.61-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix not removing focus style on blur

6daa73c

LucioChavezFuentes requested a review from a team as a code owner April 25, 2022 16:39

melvin-bot bot requested review from rushatgabhane and stitesExpensify and removed request for a team April 25, 2022 16:39

LucioChavezFuentes mentioned this pull request Apr 25, 2022

[HOLD for payment 2022-05-24] [$1000] [HOLD for payment after regression testing] Refactor Picker to be compatible with Form #7535

Closed

luacmartins self-requested a review April 25, 2022 16:44

add comment

178b8fa

luacmartins reviewed Apr 25, 2022

View reviewed changes

refactor onFocus onBlur event

0dbb44d

luacmartins requested review from Santhosh-Sellavel and removed request for rushatgabhane April 26, 2022 18:11

Revert "refactor onFocus onBlur event"

d30e03e

This reverts commit 0dbb44d. Signed-off-by: LucioChavezFuentes <luciobertinchavez@gmail.com>

LucioChavezFuentes force-pushed the remove-focus-style-on-blur branch from ec56e6b to d30e03e Compare April 27, 2022 18:30

luacmartins previously approved these changes Apr 27, 2022

View reviewed changes

Santhosh-Sellavel reviewed Apr 30, 2022

View reviewed changes

merge form main

0e9054f

LucioChavezFuentes commented May 9, 2022

View reviewed changes

src/languages/en.js Show resolved Hide resolved

LucioChavezFuentes commented May 9, 2022

View reviewed changes

src/languages/es.js Show resolved Hide resolved

parasharrajat mentioned this pull request May 11, 2022

Focus outline is not getting removed on blur of the select dropdown - reported by @parasharrajat #8939

Closed

luacmartins previously approved these changes May 11, 2022

View reviewed changes

luacmartins mentioned this pull request May 11, 2022

IOS - Payments - State field doesn't have blue border. #8932

Closed

stitesExpensify reviewed May 12, 2022

View reviewed changes

src/components/Picker/BasePicker/index.js Outdated Show resolved Hide resolved

set default value to onBlur, remove check

146042f

LucioChavezFuentes dismissed luacmartins’s stale review via 146042f May 12, 2022 22:05

parasharrajat mentioned this pull request May 16, 2022

After savings the profile settings, the edited cells remains highligh… #9024

Closed

43 tasks

parasharrajat mentioned this pull request May 16, 2022

Android - Settings - After savings the profile settings, the edited cells remains highlighted #9015

Closed

stitesExpensify approved these changes May 16, 2022

View reviewed changes

luacmartins approved these changes May 16, 2022

View reviewed changes

luacmartins merged commit 82b97bf into Expensify:main May 16, 2022

OSBotify mentioned this pull request May 16, 2022

Deploy Checklist: New Expensify 2022-05-16 #9037

Closed

15 tasks

kavimuru mentioned this pull request May 16, 2022

mWeb / Chrome - Blue outline focus isn't disappeared #9041

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing focus style on blur - Web/Desktop #8765

Removing focus style on blur - Web/Desktop #8765

LucioChavezFuentes commented Apr 25, 2022 •

edited

Loading

melvin-bot bot commented Apr 25, 2022

luacmartins left a comment

LucioChavezFuentes commented Apr 25, 2022

LucioChavezFuentes commented Apr 26, 2022

luacmartins commented Apr 26, 2022

rushatgabhane commented Apr 26, 2022 •

edited

Loading

LucioChavezFuentes commented Apr 26, 2022 •

edited

Loading

luacmartins commented Apr 27, 2022

LucioChavezFuentes commented Apr 27, 2022

LucioChavezFuentes commented Apr 27, 2022

luacmartins left a comment

Santhosh-Sellavel commented Apr 29, 2022

Santhosh-Sellavel commented Apr 29, 2022 •

edited

Loading

LucioChavezFuentes commented Apr 29, 2022

LucioChavezFuentes commented Apr 29, 2022

Santhosh-Sellavel commented Apr 30, 2022 •

edited

Loading

Santhosh-Sellavel left a comment

LucioChavezFuentes commented May 5, 2022

LucioChavezFuentes commented May 9, 2022

luacmartins left a comment

stitesExpensify left a comment

Santhosh-Sellavel commented May 12, 2022

Santhosh-Sellavel commented May 12, 2022

luacmartins commented May 12, 2022

stitesExpensify commented May 12, 2022

parasharrajat commented May 16, 2022

stitesExpensify left a comment

luacmartins left a comment

luacmartins commented May 16, 2022

OSBotify commented May 16, 2022

OSBotify commented May 17, 2022

Removing focus style on blur - Web/Desktop #8765

Removing focus style on blur - Web/Desktop #8765

Conversation

LucioChavezFuentes commented Apr 25, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web / Safari

Desktop

iOS

Android

Android/ Chrome

melvin-bot bot commented Apr 25, 2022

luacmartins left a comment

Choose a reason for hiding this comment

LucioChavezFuentes commented Apr 25, 2022

LucioChavezFuentes commented Apr 26, 2022

luacmartins commented Apr 26, 2022

rushatgabhane commented Apr 26, 2022 • edited Loading

LucioChavezFuentes commented Apr 26, 2022 • edited Loading

luacmartins commented Apr 27, 2022

LucioChavezFuentes commented Apr 27, 2022

LucioChavezFuentes commented Apr 27, 2022

luacmartins left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel commented Apr 29, 2022

Santhosh-Sellavel commented Apr 29, 2022 • edited Loading

LucioChavezFuentes commented Apr 29, 2022

LucioChavezFuentes commented Apr 29, 2022

Santhosh-Sellavel commented Apr 30, 2022 • edited Loading

PR Reviewer Checklist

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

LucioChavezFuentes commented May 5, 2022

LucioChavezFuentes commented May 9, 2022

luacmartins left a comment

Choose a reason for hiding this comment

stitesExpensify left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel commented May 12, 2022

Santhosh-Sellavel commented May 12, 2022

luacmartins commented May 12, 2022

stitesExpensify commented May 12, 2022

parasharrajat commented May 16, 2022

stitesExpensify left a comment

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented May 16, 2022

OSBotify commented May 16, 2022

OSBotify commented May 17, 2022

LucioChavezFuentes commented Apr 25, 2022 •

edited

Loading

rushatgabhane commented Apr 26, 2022 •

edited

Loading

LucioChavezFuentes commented Apr 26, 2022 •

edited

Loading

Santhosh-Sellavel commented Apr 29, 2022 •

edited

Loading

Santhosh-Sellavel commented Apr 30, 2022 •

edited

Loading