Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IOU badge disappearing after sending money to same user #8816

Merged
merged 8 commits into from
Apr 29, 2022
Merged

Fix IOU badge disappearing after sending money to same user #8816

merged 8 commits into from
Apr 29, 2022

Commits on Apr 28, 2022

  1. fix bug where IOUBadge dissapears after sending money

    @Julesssss
    Julesssss committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    d82153b View commit details
    Browse the repository at this point in the history

  2. invert IOU action type condition to prevent undesired early return

    @Julesssss
    Julesssss committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    dedd7f7 View commit details
    Browse the repository at this point in the history

  3. revert unnecessary return, used to confirm bug fix

    @Julesssss
    Julesssss committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    dc1460a View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. improve solution by excluding the send money flow

    @Julesssss
    Julesssss committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    7858d13 View commit details
    Browse the repository at this point in the history

  2. revert condition, as returning early prevents notification from displ… 

    …aying
    @Julesssss
    Julesssss committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    dd831f1 View commit details
    Browse the repository at this point in the history

  3. improve function documentation, to better explain the problem being s… 

    …olved
    @Julesssss
    Julesssss committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    7c9005f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into jules-fixIOUBadgeLostAfterSendingMoney

    @Julesssss
    Julesssss committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    a1bc5f6 View commit details
    Browse the repository at this point in the history

  5. further simplify function docs and fix lint errors

    @Julesssss
    Julesssss committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    4cd800d View commit details
    Browse the repository at this point in the history