Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File permission update #8863

Closed
wants to merge 1 commit into from
Closed

Conversation

chiragsalian
Copy link
Contributor

@chiragsalian chiragsalian commented May 3, 2022

Details

On dev my permission of the file was like so,

 chirag  ~/Expensidev/App/scripts   main <B>  ls -l
total 32
-rwxr-xr-x  1 chirag  staff  714 Apr 20 18:34 build-desktop.sh
-rwxr-xr-x  1 chirag  staff  287 Apr 11 07:27 react-native-web.sh
-rw-r--r--  1 chirag  staff  901 May  3 10:56 set-pusher-suffix.sh
-rw-r--r--  1 chirag  staff  486 Apr 11 07:27 shellUtils.sh

So when i ran npm i it would fail with this error. Updated the file permission in this PR to 777.

Fixed Issues

https://expensify.slack.com/archives/C3BGN04K1/p1651604264005359

Tests

  1. On dev in App cd into /scripts. Run ls -l and confirm you see,
-rwxrwxrwx  1 chirag  staff  901 May  3 10:56 set-pusher-suffix.sh

QA Steps

None

  • Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@chiragsalian chiragsalian self-assigned this May 3, 2022
@chiragsalian chiragsalian marked this pull request as ready for review May 3, 2022 19:04
@chiragsalian chiragsalian requested a review from a team as a code owner May 3, 2022 19:04
@melvin-bot melvin-bot bot requested review from sketchydroide and removed request for a team May 3, 2022 19:04
@Beamanator
Copy link
Contributor

Beamanator commented May 4, 2022

Thanks @chiragsalian - looks like @kidroca made the same fix here: #8862

@Beamanator Beamanator closed this May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants