Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the ready state of active clients #9082

Merged
merged 1 commit into from
May 19, 2022
Merged

Simplify the ready state of active clients #9082

merged 1 commit into from
May 19, 2022

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented May 18, 2022

Details

This was a simplification I noticed in the code

Fixed Issues

None

Tests & QA

  1. Open a chat
  2. Go offline
  3. Add a new comment
  4. Open the dev console > network tab and clear out all requests
  5. Go back online
  6. Verify that a network request happens for adding the new comment

@tgolen tgolen self-assigned this May 18, 2022
@tgolen tgolen marked this pull request as ready for review May 18, 2022 20:33
@tgolen tgolen requested a review from a team as a code owner May 18, 2022 20:33
@melvin-bot melvin-bot bot requested review from techievivek and removed request for a team May 18, 2022 20:33
techievivek
techievivek approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@techievivek techievivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and verified that it worked locally.

@techievivek techievivek merged commit 5c62c4d into main May 19, 2022
@techievivek techievivek deleted the tgolen-onready-activeclients branch May 19, 2022 15:07
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request May 19, 2022
Closed
24 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @techievivek in version: 1.1.64-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.64-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced May 26, 2022
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techievivek techievivek techievivek approved these changes

Assignees

@tgolen tgolen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgolen @OSBotify @techievivek