Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the ready state of network store #9083

Merged
merged 1 commit into from
May 18, 2022

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented May 18, 2022

Details

This was a simplification I noticed in the code

Fixed Issues

None

Tests & QA

  1. Use the application and verify that network requests are happening

@tgolen tgolen self-assigned this May 18, 2022
@tgolen tgolen marked this pull request as ready for review May 18, 2022 20:46
@tgolen tgolen requested a review from a team as a code owner May 18, 2022 20:46
@melvin-bot melvin-bot bot requested review from luacmartins and removed request for a team May 18, 2022 20:46
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well!

@luacmartins luacmartins merged commit d387f0e into main May 18, 2022
@luacmartins luacmartins deleted the tgolen-onready-networkstore branch May 18, 2022 22:55
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.64-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.64-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants