Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewDot API] Command Refactor - Inbox_CallUser_WaitTime #9220

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

nkuoch
Copy link
Contributor

@nkuoch nkuoch commented May 30, 2022

Fixed Issues

$ https://github.com/Expensify/App/issues/

Tests

Same as QA steps

QA Steps

On Concierge chat, click the phone icon. Make sure the estimated wait time gets displayed.

Screenshots

Web

image

image

@nkuoch nkuoch self-assigned this May 30, 2022
@nkuoch nkuoch changed the base branch from main to nat-api May 30, 2022 14:36
Base automatically changed from nat-api to main May 31, 2022 15:36
@nkuoch nkuoch marked this pull request as ready for review May 31, 2022 15:45
@nkuoch nkuoch requested a review from a team as a code owner May 31, 2022 15:45
@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team May 31, 2022 15:45
@nkuoch nkuoch requested review from MariaHCD and removed request for amyevans June 1, 2022 11:24
Copy link
Contributor

@MariaHCD MariaHCD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just that the linked issue in the PR description is missing. I think you meant this one: https://github.com/Expensify/Expensify/issues/211237

@MariaHCD MariaHCD merged commit 9a28393 into main Jun 1, 2022
@MariaHCD MariaHCD deleted the nat-requestcallpage branch June 1, 2022 12:19
@OSBotify
Copy link
Contributor

OSBotify commented Jun 1, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jun 1, 2022

🚀 Deployed to staging by @MariaHCD in version: 1.1.70-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

2 similar comments
@OSBotify
Copy link
Contributor

OSBotify commented Jun 1, 2022

🚀 Deployed to staging by @MariaHCD in version: 1.1.70-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jun 1, 2022

🚀 Deployed to staging by @MariaHCD in version: 1.1.70-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2022

Looks like you modified deprecatedAPI.js! To be clear, you should not be adding any code to this file.

Instead, all new API commands should use API.js, and follow our guidelines for writing new API commands.

Unsure if your change is okay? Drop a note in #expensify-open-source!

@francoisl
Copy link
Contributor

(You can ignore the message above, I'm running tests for https://github.com/Expensify/Expensify/issues/211247)

@melvin-bot

This comment was marked as resolved.

@OSBotify
Copy link
Contributor

OSBotify commented Jun 6, 2022

🚀 Deployed to production by @yuwenmemon in version: 1.1.71-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants