Solved closing of keyboard on changing text field on profile page

src/CONST.js

@@ -758,6 +758,7 @@ const CONST = {
     // There's a limit of 60k characters in Auth - https://github.com/Expensify/Auth/blob/198d59547f71fdee8121325e8bc9241fc9c3236a/auth/lib/Request.h#L28
     MAX_COMMENT_LENGTH: 60000,
 
+    FORM_CHARACTER_LIMIT: 50,
     AVATAR_CROP_MODAL: {
         // The next two constants control what is min and max value of the image crop scale.
         // Values define in how many times the image can be bigger than its container.
@@ -791,6 +792,9 @@ const CONST = {
         INVITE: 'invite',
         LEAVE_ROOM: 'leaveRoom',
     },
+    PROFILE_SETTINGS_FORM: 'profileSettingsForm',
+    MAX_64BIT_LEFT_HALF: 9223372036,
+    MAX_64BIT_RIGHT_HALF: 854775807,
 
     // These split the maximum decimal value of a signed 64-bit number (9,223,372,036,854,775,807) into parts where none of them are too big to fit into a 32-bit number, so that we can
     // generate them each with a random number generator with only 32-bits of precision.

src/libs/ValidationUtils.js

@@ -321,7 +321,19 @@ function isValidRoutingNumber(number) {
  * @returns {Boolean[]}
  */
 function doesFailCharacterLimit(maxLength, valuesToBeValidated) {
-    return _.map(valuesToBeValidated, value => value.length > maxLength);
+    return _.map(valuesToBeValidated, value => value && value.length > maxLength);
+}
+
+/**
+ * Checks if each string in array is of valid length and then returns true
+ * for each string which exceeds the limit. The function trims the passed values.
+ *
+ * @param {Number} maxLength
+ * @param {String[]} valuesToBeValidated
+ * @returns {Boolean[]}
+ */
+function doesFailCharacterLimitAfterTrim(maxLength, valuesToBeValidated) {
+    return _.map(valuesToBeValidated, value => value && value.trim().length > maxLength);
 }
 
 /**
@@ -384,6 +396,7 @@ export {
     isValidSSNLastFour,
     isValidSSNFullNine,
     doesFailCharacterLimit,
+    doesFailCharacterLimitAfterTrim,
     isReservedRoomName,
     isExistingRoomName,
     isValidTaxID,

src/libs/actions/PersonalDetails.js

@@ -72,7 +72,7 @@ function getDisplayName(login, personalDetail) {
  * @returns {String}
  */
 function getMaxCharacterError(isError) {
-    return isError ? Localize.translateLocal('personalDetails.error.characterLimit', {limit: 50}) : '';
+    return isError ? Localize.translateLocal('personalDetails.error.characterLimit', {limit: CONST.FORM_CHARACTER_LIMIT}) : '';
 }
 
 /**
@@ -263,7 +263,6 @@ function setPersonalDetails(details, shouldGrowl) {
 }
 
 function updateProfile(firstName, lastName, pronouns, timezone) {
-    const myPersonalDetails = personalDetails[currentUserEmail];
     API.write('UpdateProfile', {
         firstName,
         lastName,
@@ -286,19 +285,6 @@ function updateProfile(firstName, lastName, pronouns, timezone) {
                 },
             },
         }],
-        failureData: [{
-            onyxMethod: CONST.ONYX.METHOD.MERGE,
-            key: ONYXKEYS.PERSONAL_DETAILS,
-            value: {
-                [currentUserEmail]: {
-                    firstName: myPersonalDetails.firstName,
-                    lastName: myPersonalDetails.lastName,
-                    pronouns: myPersonalDetails.pronouns,
-                    timezone: myPersonalDetails.timeZone,
-                    displayName: myPersonalDetails.displayName,
-                },
-            },
-        }],
     });
 }