Code

Refactor TransferWalletBalance#9589

Code

Merged

thienlnam merged 54 commits intomainExpensify/App:mainfrom maria-refactor-transfer-wallet-balanceExpensify/App:maria-refactor-transfer-wallet-balanceCopy head branch name to clipboardJul 22, 2022

+187-89

Commits

Commits on Jun 28, 2022

• Use new API command: TransferBalance

  MariaHCD

  committed
  6b71211

• Remove unnecessary saveWalletTransferAmount method

  MariaHCD

  committed
  2f7b9cc

• Remove usage of deprecated API command

  MariaHCD

  committed
  aec6865

• Fix JSDoc and remove unused import

  MariaHCD

  committed
  a4f35dd

Commits on Jun 30, 2022

• Add successful balance transfer page

  MariaHCD

  committed
  6f4c9bb

• Fixes for successful transfer balance page

  MariaHCD

  committed
  3e5fee2

• Show transfer success page

  MariaHCD

  committed
  60eed1c

• Add showShouldTransferSuccess Onyx prop

  MariaHCD

  committed
  ae22a8b

• Import routes

  MariaHCD

  committed
  eaed050

• Add close button

  MariaHCD

  committed
  8ede4a9

• Allow success and failure data to be set for refactored commands

  MariaHCD

  committed
  93fe910

• Style fixes

  MariaHCD

  committed
  bd830bd

• Rename api command

  MariaHCD

  committed
  fea3749

• Update success transfer message

  MariaHCD

  committed
  79e80d9

• Update success message

  MariaHCD

  committed
  de4847c

• Remove unused confirm modal

  MariaHCD

  committed
  217c071

Commits on Jul 1, 2022

• Delete successful transfer balance page

  MariaHCD

  committed
  c70a5ea

• Style fixes

  MariaHCD

  committed
  a3aa6b1

Commits on Jul 6, 2022

• Merge remote-tracking branch 'origin/main' into maria-refactor-transfer-wallet-balance

  MariaHCD

  committed
  7419781

Commits on Jul 7, 2022

• Merge remote-tracking branch 'origin/main' into maria-refactor-transfer-wallet-balance

  MariaHCD

  committed
  ac8f06d

• Rename method

  MariaHCD

  committed
  725900b

• Specify that we want the API to return onyxData

  MariaHCD

  committed
  93bbb80

Commits on Jul 8, 2022

• Merge remote-tracking branch 'origin/main' into maria-refactor-transfer-wallet-balance

  Show description for 96ed727
  MariaHCD

  committed
  96ed727

• Update transfer balance success screen

  MariaHCD

  committed
  114f2d5

• Update success text

  MariaHCD

  committed
  81ec21e

• Remove unused text and translations

  MariaHCD

  committed
  247b557

• Fix capitalization

  MariaHCD

  committed
  bc8ad80

• Add Spanish translations

  MariaHCD

  committed
  173255a

Commits on Jul 11, 2022

• Add TadaBlue illustration

  MariaHCD

  committed
  3cb64a0

• Use blue tada icon

  MariaHCD

  committed
  88f1a41

Commits on Jul 12, 2022

• Remove unused prop transferAmount

  MariaHCD

  committed
  6cd7456

• Remove unused shouldShowConfirmModal and dismissWalletConfirmModal

  MariaHCD

  committed
  e794b9f

• Rename to shouldShowSuccess

  MariaHCD

  committed
  956cd08

Commits on Jul 13, 2022

• Remove unused transferAmount prop

  MariaHCD

  committed
  2ed73e0

• Merge remote-tracking branch 'origin/main' into maria-refactor-transfer-wallet-balance

  MariaHCD

  committed
  7046e6c

Commits on Jul 15, 2022

• Add copy for debit card transfer success

  MariaHCD

  committed
  76eb693

• Show success message based on payment method type

  MariaHCD

  committed
  6891d26

• Style fix

  MariaHCD

  committed
  9da172d

Commits on Jul 18, 2022

• Add translation

  MariaHCD

  committed
  0e766f1

• Disable transfer balance if offline

  MariaHCD

  committed
  d900116

• Disable transfer button if offline

  MariaHCD

  committed
  bdd1b55

• Merge remote-tracking branch 'origin/main' into maria-refactor-transfer-wallet-balance

  MariaHCD

  committed
  ec86579

Commits on Jul 19, 2022

• Merge remote-tracking branch 'origin/main' into maria-refactor-transfer-wallet-balance

  MariaHCD

  committed
  7564b3c

• Add containerStyles prop to OfflineIndicator

  MariaHCD

  committed
  193ed3f

• Add OfflineIndicator to BasePaymentsPage and TransferBalancePage

  MariaHCD

  committed
  cc59b0a

Commits on Jul 20, 2022

• Adjust icon and styles for OfflineIndicator

  MariaHCD

  committed
  1796df0

• Merge remote-tracking branch 'origin/main' into maria-refactor-transfer-wallet-balance

  Show description for 1d50772
  MariaHCD

  committed
  1d50772

• Fix styling of OfflineIndicator on TransferBalancePage

  MariaHCD

  committed
  7909bbb

Commits on Jul 21, 2022

• Fix icon size for OfflineIndicator

  MariaHCD

  committed
  706d90b

• Merge remote-tracking branch 'origin/main' into maria-refactor-transfer-wallet-balance

  Show description for 84f9837
  MariaHCD

  committed
  84f9837

• Fix errors from merge conflicts

  MariaHCD

  committed
  d34fd5c

• Optionally override default styles for OfflineIndicator

  MariaHCD

  committed
  1eebd13

• fix conflicts

  ctkochan22

  committed
  514e874

• use new prop

  ctkochan22

  committed
  e4550d6