Improvement BasePaymentPage #9622

JosueEchandiaAsto · 2022-06-29T03:30:45Z

Details

The Add Payment Methods button will align to the bottom edge and menu popups will align to the right

Fixed Issues

#8929

Tests

Verify that the Add Payment Methods button aligns to the bottom edge
Check that the menus are positioned correctly when resizing the browser
Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

QA Steps

Open app
Log in any account
Setting>Payments
Verify that the Add Payment Methods button aligns to the bottom edge
Show any payment menu
If it is on desktop/web, modify the size of the browser/app and verify that the popup menus are positioned correctly
Check that the menus are positioned correctly when resizing the browser

Screenshots

Web

Safari

Grabacion.de.pantalla.2022-09-16.a.la.s.12.23.05.mov

Chrome

Grabacion.de.pantalla.2022-09-16.a.la.s.12.26.11.mov

Mozila

Grabacion.de.pantalla.2022-09-16.a.la.s.12.27.06.mov

Mobile Web

Simulator.Screen.Recording.-.iPhone.13.-.2022-09-16.at.12.28.35.mp4

Desktop

Grabacion.de.pantalla.2022-09-16.a.la.s.12.31.42.mov

iOS

Simulator.Screen.Recording.-.iPhone.13.-.2022-09-16.at.12.37.35.mp4

Android

Grabacion.de.pantalla.2022-09-16.a.la.s.12.41.12.mov

src/pages/settings/Payments/PaymentMethodList.js

src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

mananjadhav

Requested small changes, rest on web looks fine. Once fixed, I'll test on other platforms.

JosueEchandiaAsto · 2022-07-04T01:30:54Z

Small requested changes made

mananjadhav · 2022-07-05T09:53:23Z

I'll check this today and test.

src/pages/settings/Payments/PaymentMethodList.js

src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

JosueEchandiaAsto · 2022-07-07T01:32:07Z

@mananjadhav @parasharrajat
Can I delete dimensionsSubscription? It is crossing with the withWindowDimensions listener. It seems unnecessary to me because withWindowDimensions will be used.

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Line 67 in 75e4731

    
           this.dimensionsSubscription = Dimensions.addEventListener('change', this.setMenuPosition);

Replacing window.innerWidth with this.props.windowWidth of withWindowDimensions does the following:

Grabacion.de.pantalla.2022-07-06.a.la.s.20.21.21.mov

roryabraham · 2022-07-07T02:07:01Z

Can I delete dimensionsSubscription? It is crossing with the withWindowDimensions listener. It seems unnecessary to me because withWindowDimensions will be used.

@JosueEchandiaAsto Yes, you can replace dimensionsSubscription with the withWindowDimensions listener, and just listen for changes in the window dimensions props in componentDidUpdate 👍

JosueEchandiaAsto · 2022-07-07T02:38:21Z

the following changes were made

bounces={false} was removed on PaymentMethodList
dimensionsSubscription replaced with the withWindowDimensions listener
Avoided creating the setPositionAddPaymentMenu method but continuing to use setPositionAddPaymentMethod that was used initially

roryabraham · 2022-07-08T22:27:56Z

@JosueEchandiaAsto Just FYI you've got conflicts in this PR

JosueEchandiaAsto · 2022-07-08T22:32:01Z

@roryabraham
Ok, I'll check it out. Can i create another PR?

mananjadhav · 2022-07-11T18:02:33Z

Ok, I'll check it out. Can i create another PR?

@JosueEchandiaAsto You can pull the latest main branch changes and resolve the conflicts.

JosueEchandiaAsto · 2022-07-11T18:30:14Z

Resolved conflicts. Any additional observation?

mananjadhav · 2022-07-11T18:37:31Z

@JosueEchandiaAsto I took your latest pull and while code changes look good, I had some trouble testing this with Mac Safari while resizing the window.

screen-resize-payment-button-position.mp4

Also you need to go through every item in the checklist and mark it even if it doesn't apply for the PR. This is to ensure we've verified every item in the checklist, and there's one small change in lint error. Removing FormAlertWrapper import from PaymentMethodList

JosueEchandiaAsto · 2022-07-11T18:43:37Z

@mananjadhav wait a moment, in the main branch there is a change that uses FormAlertWrapper, I'm doing the update.
This is new.
<FormAlertWrapper> {isOffline => (

App/src/pages/settings/Payments/PaymentMethodList.js

Lines 214 to 228 in ff1b9cd

    
           <FormAlertWrapper> 
        
               {isOffline => ( 
        
                   <Button 
        
                       text={item.text} 
        
                       icon={item.icon} 
        
                       onPress={item.onPress} 
        
                       isDisabled={item.isDisabled || isOffline} 
        
                       style={item.style} 
        
                       iconStyles={item.iconStyles} 
        
                       success={item.success} 
        
                       shouldShowRightIcon={item.shouldShowRightIcon} 
        
                       extraLarge 
        
                   /> 
        
               )} 
        
           </FormAlertWrapper>

mananjadhav · 2022-07-11T18:45:28Z

Thanks for picking it up @JosueEchandiaAsto

roryabraham

After this change, we only have one type of item that goes in this list: MENU_ITEM. The only other non-menuItem is added right here on lines 140-145, when the list rendered by the FlatList is empty.

FlatList has a prop just for this called ListEmptyComponent, so we should use that.

In summary, the changes I'm requesting are:

Get rid of the type field on items in the PaymentMethodList and the MENU_ITEM const.
Use the ListEmptyComponent to render the addFirstPaymentMethod test if the list is empty
Get rid of the conditional rendering in renderItem

Thanks!

mananjadhav · 2022-08-09T19:26:51Z

@JosueEchandiaAsto Did you get a chance to look at @roryabraham's comment?

JosueEchandiaAsto · 2022-08-11T21:53:46Z

@mananjadhav Yes, I will make the change, along with the new conflicts again.

mananjadhav · 2022-08-18T04:27:29Z

@JosueEchandiaAsto Do we have any updates on the PR?

parasharrajat · 2022-08-30T16:10:59Z

Bump...

JosueEchandiaAsto · 2022-09-15T06:28:15Z

@roryabraham Requested changes are done

mananjadhav

Few small comments @JosueEchandiaAsto. Apart from that can you please:

Take the latest main pull
Screencasts seem to be outdated (missing > in the button text). Can you please update the screenshot/videos with the latest rerun.

src/pages/settings/Payments/PaymentMethodList.js

JosueEchandiaAsto · 2022-09-16T17:42:32Z

@mananjadhav Requested changes are done. Screencasts updated

This warning appears, but it isn't related to this issue.

mananjadhav · 2022-09-17T19:42:20Z

This warning appears, but it isn't related to this issue.

Thanks @JosueEchandiaAsto for the changes. Yeah it exists on main as well.

@roryabraham The code looks good to me and tests well.

🎀 👀 🎀
C+ reviewed

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

mananjadhav · 2022-09-20T04:01:29Z

@roryabraham Quick bump.

roryabraham

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

melvin-bot · 2022-09-21T17:49:35Z

@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

roryabraham · 2022-09-21T17:50:15Z

Contributor had used an out-of-date checklist, and I chose to merge anyways for the sake of velocity.

OSBotify · 2022-09-21T17:53:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-09-21T19:30:47Z

🚀 Deployed to staging by @roryabraham in version: 1.2.4-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-09-22T18:44:00Z

🚀 Deployed to production by @luacmartins in version: 1.2.4-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Use quotation marks

75e4731

JosueEchandiaAsto requested a review from a team as a code owner June 29, 2022 03:30

melvin-bot bot requested review from mananjadhav and roryabraham and removed request for a team June 29, 2022 03:30

JosueEchandiaAsto mentioned this pull request Jun 29, 2022

[$250 - Payment Due 9/28] IOS - Payments - The button "Add payment method" is not visible when scrolled up #8929

Closed

mananjadhav reviewed Jul 3, 2022

View reviewed changes

src/pages/settings/Payments/PaymentMethodList.js Show resolved Hide resolved

mananjadhav reviewed Jul 3, 2022

View reviewed changes

src/pages/settings/Payments/PaymentMethodList.js Outdated Show resolved Hide resolved

mananjadhav reviewed Jul 3, 2022

View reviewed changes

src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js Outdated Show resolved Hide resolved

mananjadhav suggested changes Jul 3, 2022

View reviewed changes

Requested small changes

db74810

parasharrajat reviewed Jul 6, 2022

View reviewed changes

src/pages/settings/Payments/PaymentMethodList.js Outdated Show resolved Hide resolved

parasharrajat reviewed Jul 6, 2022

View reviewed changes

src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js Outdated Show resolved Hide resolved

parasharrajat mentioned this pull request Jul 6, 2022

[$2000] iPad - UI Inconsistency of the popover menus - reported by @Santhosh-Sellavel #7375

Closed

JosueEchandiaAsto added 2 commits July 6, 2022 21:29

dimensionsSubscription Removed

2285d07

Rollback remove bounce in PaymentMethodList

a6bc7c6

Merge branch 'main' into Fix-Issue8929

f6d98c6

FormAlertWrapper in PaymentMethodList

6e72f30

roryabraham requested changes Aug 2, 2022

View reviewed changes

JosueEchandiaAsto added 4 commits September 15, 2022 00:45

Resolve conflicts

251213a

Improve PaymentMethodList

99a4f6a

Requested changes

1bf2aa1

Missing styles

2863784

JosueEchandiaAsto requested a review from roryabraham September 15, 2022 06:29

mananjadhav suggested changes Sep 16, 2022

View reviewed changes

src/pages/settings/Payments/PaymentMethodList.js Outdated Show resolved Hide resolved

src/pages/settings/Payments/PaymentMethodList.js Outdated Show resolved Hide resolved

src/pages/settings/Payments/PaymentMethodList.js Outdated Show resolved Hide resolved

JosueEchandiaAsto added 2 commits September 16, 2022 12:12

Merge from main

86a7fca

Requested changes

5af7f36

roryabraham approved these changes Sep 21, 2022

View reviewed changes

roryabraham merged commit c322532 into Expensify:main Sep 21, 2022

melvin-bot bot added the Emergency label Sep 21, 2022

roryabraham removed the Emergency label Sep 21, 2022

OSBotify mentioned this pull request Sep 21, 2022

Deploy Checklist: New Expensify 2022-09-21 #11181

Closed

16 tasks

Puneet-here mentioned this pull request Oct 11, 2022

[HOLD for payment 2022-11-18] [$500] Web -Payment - Popup with payment option is hidden title for new public accounts #11414

Closed

mananjadhav mentioned this pull request May 25, 2023

[HOLD for payment 2023-05-25] [$1000] Payment delete modal menu missing margin at the top #18581

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement BasePaymentPage #9622

Improvement BasePaymentPage #9622

JosueEchandiaAsto commented Jun 29, 2022 •

edited

Loading

mananjadhav left a comment

JosueEchandiaAsto commented Jul 4, 2022

mananjadhav commented Jul 5, 2022

JosueEchandiaAsto commented Jul 7, 2022 •

edited

Loading

roryabraham commented Jul 7, 2022 •

edited

Loading

JosueEchandiaAsto commented Jul 7, 2022 •

edited

Loading

roryabraham commented Jul 8, 2022

JosueEchandiaAsto commented Jul 8, 2022

mananjadhav commented Jul 11, 2022

JosueEchandiaAsto commented Jul 11, 2022

mananjadhav commented Jul 11, 2022 •

edited

Loading

JosueEchandiaAsto commented Jul 11, 2022 •

edited

Loading

mananjadhav commented Jul 11, 2022

roryabraham left a comment

mananjadhav commented Aug 9, 2022

JosueEchandiaAsto commented Aug 11, 2022

mananjadhav commented Aug 18, 2022

parasharrajat commented Aug 30, 2022

JosueEchandiaAsto commented Sep 15, 2022

mananjadhav left a comment

JosueEchandiaAsto commented Sep 16, 2022 •

edited

Loading

mananjadhav commented Sep 17, 2022 •

edited

Loading

PR Reviewer Checklist

mananjadhav commented Sep 20, 2022

roryabraham left a comment

melvin-bot bot commented Sep 21, 2022

roryabraham commented Sep 21, 2022

OSBotify commented Sep 21, 2022

OSBotify commented Sep 21, 2022

OSBotify commented Sep 22, 2022

Improvement BasePaymentPage #9622

Improvement BasePaymentPage #9622

Conversation

JosueEchandiaAsto commented Jun 29, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

mananjadhav left a comment

Choose a reason for hiding this comment

JosueEchandiaAsto commented Jul 4, 2022

mananjadhav commented Jul 5, 2022

JosueEchandiaAsto commented Jul 7, 2022 • edited Loading

roryabraham commented Jul 7, 2022 • edited Loading

JosueEchandiaAsto commented Jul 7, 2022 • edited Loading

roryabraham commented Jul 8, 2022

JosueEchandiaAsto commented Jul 8, 2022

mananjadhav commented Jul 11, 2022

JosueEchandiaAsto commented Jul 11, 2022

mananjadhav commented Jul 11, 2022 • edited Loading

JosueEchandiaAsto commented Jul 11, 2022 • edited Loading

mananjadhav commented Jul 11, 2022

roryabraham left a comment

Choose a reason for hiding this comment

mananjadhav commented Aug 9, 2022

JosueEchandiaAsto commented Aug 11, 2022

mananjadhav commented Aug 18, 2022

parasharrajat commented Aug 30, 2022

JosueEchandiaAsto commented Sep 15, 2022

mananjadhav left a comment

Choose a reason for hiding this comment

JosueEchandiaAsto commented Sep 16, 2022 • edited Loading

mananjadhav commented Sep 17, 2022 • edited Loading

PR Reviewer Checklist

mananjadhav commented Sep 20, 2022

roryabraham left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 21, 2022

roryabraham commented Sep 21, 2022

OSBotify commented Sep 21, 2022

OSBotify commented Sep 21, 2022

OSBotify commented Sep 22, 2022

JosueEchandiaAsto commented Jun 29, 2022 •

edited

Loading

JosueEchandiaAsto commented Jul 7, 2022 •

edited

Loading

roryabraham commented Jul 7, 2022 •

edited

Loading

JosueEchandiaAsto commented Jul 7, 2022 •

edited

Loading

mananjadhav commented Jul 11, 2022 •

edited

Loading

JosueEchandiaAsto commented Jul 11, 2022 •

edited

Loading

JosueEchandiaAsto commented Sep 16, 2022 •

edited

Loading

mananjadhav commented Sep 17, 2022 •

edited

Loading