Delete comment - Deleted comment is still visible in receiver side

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Expected Result:

Deleted comment should not be visible for receiver after it has been deleted.

Actual Result:

Deleted comment is still visible in receiver side and it only shows a blank attachment. When login out and in again the comment is not visible.

Action Performed:

Pre-requisite: be logged in to sender and receiver accounts at the same time.

1. As the sender account, send an image to account B (receiver)
2. Delete the comment with the image.
3. As the receiver account, check the conversation with the sender account.

Workaround:

Login out and in again will not show the deleted comment anymore.

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.58-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Found while executing QA for #2046

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[isagoico]

Added the deploy blocker label since the Delete comment feature has not hit production yet.

[MariaHCD]

Tagging @sketchydroide as you worked on the original issue! 🙌🏼

[sketchydroide]

Thanks @MariaHCD.

Hmm, not sure what is happening, but I'll take a look

[sketchydroide]

Might need some help sorting this out, I think I know what is happening, but not sure on how to fix it.
So when someone deletes the attachement they are changing '[Attachment]' to '' wich basically sets the comment as no longer being an attachement but I assume all the attachement information would still be around. I think this might need a bit more work on the Web side, but maybe not a bug on e.cash itself.
Or maybe we should no able to delete attachements for now, and the logic to shouldShow should be the same for both edit and delete.

Any thought and inputs @rory @yuwenmemon @marcaaron?

[roryabraham]

I just merged a contributor PR which implements a separate function called canEditReportAction and uses it to determine whether or not to show these actions. It should return false for any attachment reportActions, and should temporarily resolve this to prevent it from being a deploy blocker.

[sketchydroide]

ok cool, I've checked the PR, and it does one of the things I suggested, so I'm happy that this should no longer be a deploy blocker @isagoico can we check please :)

To be clear we can no longer delete attachements, the delete button should not be visible anymore for attachements.

[isagoico]

Checked and the option to delete is not there 🎉 Removing deploy blocker label

[sketchydroide]

Ok closing this one then, as we can't reproduce it anymore, and we will probably need make a decision on how to handle attachements somewhere else.