Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: Expensify.cash 2021-05-28 #3199

Closed
27 tasks done
OSBotify opened this issue May 28, 2021 · 11 comments
Closed
27 tasks done

Deploy Checklist: Expensify.cash 2021-05-28 #3199

OSBotify opened this issue May 28, 2021 · 11 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented May 28, 2021

Release Version: 1.0.59-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads

@roryabraham
Copy link
Contributor

Locking this as part of testing for #2978

@roryabraham roryabraham added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging labels May 28, 2021
@roryabraham
Copy link
Contributor

Unlocking to fix staging before the weekend

@isagoico
Copy link

Starting QA!

@isagoico isagoico added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 31, 2021
@isagoico
Copy link

Adding #3222 manually to the list.

@isagoico isagoico removed the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 31, 2021
@jasperhuangg
Copy link
Contributor

jasperhuangg commented Jun 1, 2021

Hi @isagoico! Is there any way that #3174 can be taken off of the deploy checklist? There's another PR it's dependent on that I don't think is going to be ready yet. It's my fault! I forgot to stick it on [HOLD].

I've reverted it here: #3257, going to remove it!

@isagoico
Copy link

isagoico commented Jun 1, 2021

Starting QA!

@isagoico isagoico added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 1, 2021
@isagoico
Copy link

isagoico commented Jun 1, 2021

Manually adding #3058 which was not automatically added to the list.

@isagoico
Copy link

isagoico commented Jun 1, 2021

Regression is finished!
1 issue found today.

  1. App - Emoji - There's a small delay when adding emoji using the emoji picker #3274

PRs are finished too.
No comments added.

Thanks!

@isagoico
Copy link

isagoico commented Jun 1, 2021

:shipit:

@isagoico isagoico closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants