Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD Auth 5613] [IOU] Pay with Expensify option #3174

Merged
merged 5 commits into from
May 31, 2021

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented May 27, 2021

Details

Added the option to pay with Expensify in the IOU Details modal if the report has USD set as its currency. See the issue for more context.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/159572

Tests

  1. Created 3 users (A, B, and C) with Gold Expensify Wallets (via this SO)
  2. Used A to submit an IOU Request to B and C.
  3. Used the Pay with Expensify option to pay for B and C.
  4. Verified that the payments were added in the reimbursements table:
SELECT * from reimbursements WHERE reportID=[reportID];

QA Steps

Same as the above tests.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-05-27 at 9 57 13 AM

Mobile Web

Simulator Screen Shot - iPhone 11 - 2021-05-27 at 10 04 49
Simulator Screen Shot - iPhone 11 - 2021-05-27 at 10 04 55

Desktop

Screen Shot 2021-05-27 at 9 59 10 AM

iOS

Simulator Screen Shot - iPhone 11 - 2021-05-27 at 10 02 43
Simulator Screen Shot - iPhone 11 - 2021-05-27 at 10 02 46

Android

171622081774_ pic
181622081775_ pic

@jasperhuangg jasperhuangg self-assigned this May 27, 2021
@jasperhuangg jasperhuangg marked this pull request as ready for review May 28, 2021 05:04
@jasperhuangg jasperhuangg requested a review from a team as a code owner May 28, 2021 05:04
@MelvinBot MelvinBot requested review from Gonals and removed request for a team May 28, 2021 05:05
@jasperhuangg
Copy link
Contributor Author

@Gonals Ready for review, thanks!

@Gonals
Copy link
Contributor

Gonals commented May 28, 2021

Should this be hidden behind a beta?

@jasperhuangg
Copy link
Contributor Author

jasperhuangg commented May 31, 2021

@Gonals Hmm you're probably right, all the Web-E code that this calls is hidden behind BETA_EXPENSIFY_WALLET. Is this enough, or do we need to also enable it here?

Did some snooping around and it seems like all of the IOU functionality is already behind a beta, which includes the ability to access this option in the IOU Details modal; although you can still access it via the URL (you just can't access it via the UI), but I think that's to be expected.

Did you have something else in mind?

@Gonals Gonals merged commit 01b2091 into main May 31, 2021
@Gonals Gonals deleted the jasper-IOUPayWithExpensifyOption branch May 31, 2021 13:31
@isagoico
Copy link

@jasperhuangg @Gonals Not sure if we're able to test this on our side. We don't have accounts with Gold Expensify Wallets.

@jasperhuangg jasperhuangg changed the title [IOU] Pay with Expensify option [HOLD Auth 5613] [IOU] Pay with Expensify option Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants