Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SSRI to latest version #3251

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Update SSRI to latest version #3251

merged 1 commit into from
Jun 1, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented May 31, 2021

Details

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/165509
Fixes https://github.com/Expensify/Expensify/issues/165508

Tests

  • Loaded the site, played around with it
  • Checked the changelog here only contains the fix for the regex this vulnerability is complaining about

QA Steps

No

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@iwiznia iwiznia requested a review from a team May 31, 2021 22:51
@iwiznia iwiznia self-assigned this May 31, 2021
@botify
Copy link

botify commented May 31, 2021

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team May 31, 2021 22:51
@iwiznia
Copy link
Contributor Author

iwiznia commented May 31, 2021

Yes Botify, this is a dependency of a dependency, so no changes in package.json are needed.

@HorusGoul HorusGoul merged commit 14b35a7 into main Jun 1, 2021
@HorusGoul HorusGoul deleted the ionatan_update_ssri branch June 1, 2021 08:42
@OSBotify OSBotify mentioned this pull request Jun 1, 2021
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HorusGoul HorusGoul HorusGoul approved these changes

Assignees

@iwiznia iwiznia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwiznia @botify @HorusGoul