Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CP user validation #3213

Merged
merged 1 commit into from
May 28, 2021
Merged

Fix CP user validation #3213

merged 1 commit into from
May 28, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented May 28, 2021

Fixes failed workflow run: https://github.com/Expensify/Expensify.cash/actions/runs/886410085

Validation that it works: https://github.com/Expensify/Expensify.cash/runs/2696855202?check_suite_focus=true

I manually ran that CP workflow from this branch: Rory-FixCPUserValidation

@roryabraham roryabraham changed the title remove string comparison Fix CP user validation May 28, 2021
@roryabraham roryabraham self-assigned this May 28, 2021
@roryabraham roryabraham marked this pull request as ready for review May 28, 2021 18:41
@roryabraham roryabraham requested a review from a team as a code owner May 28, 2021 18:41
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team May 28, 2021 18:41
@AndrewGable
Copy link
Contributor

Looks good! Skipping e2e to continue testing.

@AndrewGable AndrewGable merged commit cd1cec3 into main May 28, 2021
@AndrewGable AndrewGable deleted the Rory-FixCPUserValidation branch May 28, 2021 18:42
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants