-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create lockDeploys workflow #1938
Conversation
Testing step 1: LockDeploys workflow: https://github.com/Expensify/Expensify.cash/runs/2151878987?check_suite_focus=true preDeploy after master PR was merged: https://github.com/Expensify/Expensify.cash/actions/runs/669167652 StagingDeployCash updated #1926 |
Automerge master failed silently https://github.com/Expensify/Expensify.cash/runs/2151890115?check_suite_focus=true So our new version wasn't updated on To resolve, we'll make sure there are no automerge jobs going either, and pull master after waiting. |
Testing step 1 round 2: lockDeploys workflow: https://github.com/Expensify/Expensify.cash/actions/runs/669259652 I think that after the |
Testing step 1 round 3: lockDeploys workflow: https://github.com/Expensify/Expensify.cash/actions/runs/669426206 The fact that |
Details
To avoid a race condition between this job and
preDeploy:version
, added a new action called https://github.com/TomChv/wait-my-workflow/ . Tested in Public-Test-Repo and seems to work well.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/155210
Tests
🔐 LockCashDeploys 🔐
label to theStagingDeployCash
. We should then expect that:lockDeploys
workflow should wait for thepreDeploy::version
job to finish before proceeding pastwait-my-workflow
. But then once it does...bumpVersion
action should be executed w/SEMVER_LEVEL = PATCH
PATCH
versionpreDeploy
workflow runs again, an automerge PR should be merged to staging from master.StagingDeployCash
should be updated with the newPATCH
versionStagingDeployCash
should not be modifiedStagingDeployCash
, and:PATCH
version created in step 1BUILD
version should be bumped on masterBUILD
version on master.StagingDeployCash
should be created, and should include the PR merged in step 2.🔐 LockCashDeploys 🔐
to some random issue, and this workflow should be skipped.