-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react-native for SNYK vulnerability #3446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
nickmurray47 and
AndrewGable
and removed request for
a team
June 8, 2021 22:09
timszot
commented
Jun 8, 2021
@@ -11,4 +11,4 @@ jest.mock('react-native-reanimated', () => { | |||
}); | |||
|
|||
// Silence the warning: Animated: `useNativeDriver` is not supported because the native animated module is missing | |||
jest.mock('react-native/Libraries/Animated/src/NativeAnimatedHelper'); | |||
jest.mock('react-native/Libraries/Animated/NativeAnimatedHelper'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed per this SO answer because our test were failing.
timszot
changed the title
[HOLD] Update react-native for SNYK vulnerability
Update react-native for SNYK vulnerability
Jun 8, 2021
marcaaron
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WCGW
49 tasks
🚀 Deployed to staging in version: 1.0.65-3🚀
|
This was referenced Jun 9, 2021
5 tasks
🚀 Deployed to production in version: 1.0.68-4🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Updates react-native to
0.64.1
due to a SNYK vulnerability.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/166320
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android