Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Update staging,prod from a separate branch to auto-resolve conflicts #3521

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Details in slack here, but

TL;DR CPs broke regular staging deploys like so:

  1. Bump the version in main to 1.0.66-10. Commit the change (commit hash XYX).
  2. Run git checkout staging && git cherry-pick XYX. This makes the version on staging match main.
  3. Checkout main and bump the version to 1.0.66-11. Commit the change.
  4. Run git checkout staging && git merge main -> ❌ Merge conflict in package.json, etc...

Fixed Issues

(hopefully) Fixes big ol' deploy fire 🔥

Tests

Merge this and see if a staging deploy happens. 🤞

QA Steps

None.

Tested On

Github only.

@roryabraham roryabraham self-assigned this Jun 10, 2021
@roryabraham roryabraham requested a review from a team as a code owner June 10, 2021 19:27
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team June 10, 2021 19:27
@Jag96 Jag96 merged commit 2d1f217 into main Jun 10, 2021
@Jag96 Jag96 deleted the Rory-FixUpdateStagingMergeConflict branch June 10, 2021 21:24
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.66-13🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham roryabraham changed the title Update staging,prod from a separate branch to auto-resolve conflicts [No QA] Update staging,prod from a separate branch to auto-resolve conflicts Jun 10, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants