Merge pull request #793 from FitseTLT/fix-sms-domain-in-htmlToText

Fix - Remove sms domain in htmlToText
Expensify · Aug 28, 2024 · fe7515d · fe7515d
2 parents d114661 + 3ef44c7
commit fe7515d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/__tests__/ExpensiMark-HTMLToText-test.js b/__tests__/ExpensiMark-HTMLToText-test.js
@@ -160,6 +160,10 @@ test('Mention user html to text', () => {
 
     testString = '<mention-user accountID="1234" />';
     expect(parser.htmlToText(testString, extras)).toBe('@user@domain.com');
+
+    extras.accountIDToName['1234'] = '+251924892738@expensify.sms';  
+    testString = '<mention-user accountID="1234"/>';
+    expect(parser.htmlToText(testString, extras)).toBe('@+251924892738');
 });
 
 test('Mention report html to text', () => {

diff --git a/lib/ExpensiMark.ts b/lib/ExpensiMark.ts
@@ -780,7 +780,7 @@ export default class ExpensiMark {
                         ExpensiMark.Log.alert('[ExpensiMark] Missing account name', {accountID: g1});
                         return '@Hidden';
                     }
-                    return `@${extras.accountIDToName?.[g1]}`;
+                    return `@${Str.removeSMSDomain(extras.accountIDToName?.[g1] ?? '')}`;
                 },
             },
             {