Rename .jsx files to .js and vice versa #334
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roryabraham will you please review this?
Optimistically, in making changes to the Expensify.cash desktop app, I want to avoid making webpack changes that require being able to parse JSX.
expensify-common
is not built or packed, so the imports that trace to it are made without any modifications. When the electron app tries to drive through the tree of pre-existing imports, it gets to a JSX file that causes problems.Right now
CONST.jsx
is the main offender, but I figure it's worth switching some of the others. It is worth noting that there are still lint errors, but those seem to be independent of the changes I made. Mine just elucidate them.Fixed Issues
N/A
Tests
Ran
npm lint
and saw no issues that were newly caused by renaming.Ran
npm lint
and saw no issues that were newly caused by renaming.QA