Quote support for HTML => MD Conversion #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasharrajat
changed the title
|
Grabbing this because @Luke9389 is OOO |
|
@parasharrajat Please fill out the PR template |
|
@roryabraham Updated. |
roryabraham
reviewed
Jul 29, 2021
roryabraham
reviewed
Jul 29, 2021
|
Updated. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TAG_REVIEWER will you please review this?
[Explanation of the change or anything fishy that is going on]
Added support for HTML quote parsing in HTML to MD conversion.
<blockquote>tags.> line text\nwe skip this char to remove the extra line and conversion would be>.Fixed Issues
$ Expensify/App#4188
Tests
What unit/integration tests cover your change? What autoQA tests cover your change?
I have added Unit tests that cover cases where Quotes can also contain other HTML tags or newlines.
What tests did you perform that validates your changes worked?
I used a couple of quoted texts and paste them into the Composer in the E.cash to test my solution.
QA
What does QA need to do to validate your changes?
Try to paste copied quotes from other websites to the E.cash.
What areas do they need to test for regressions?
Messaging on E.cash.