Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Add polyfill for replaceAll() to fix Safari iOS 13 #447

Merged
merged 3 commits into from
May 18, 2022
Merged

[No QA] Add polyfill for replaceAll() to fix Safari iOS 13 #447

merged 3 commits into from
May 18, 2022

Conversation

marcaaron
Copy link
Contributor

Fixed Issues (Related to)

$ Expensify/App#8896 (comment)

Tests

Can be tested in connection with -> Expensify/App#9060

QA

No QA

@marcaaron marcaaron self-assigned this May 18, 2022
@marcaaron marcaaron requested a review from a team as a code owner May 18, 2022 19:30
@melvin-bot melvin-bot bot requested review from techievivek and removed request for a team May 18, 2022 19:30
techievivek
techievivek approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@techievivek techievivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@techievivek techievivek merged commit 237fb78 into main May 18, 2022
@techievivek techievivek deleted the marcaaron-replaceAll] branch May 18, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techievivek techievivek techievivek approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcaaron @techievivek