Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix line break handling for HTML h1 to markdown conversion #502

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix line break handling for HTML h1 to markdown conversion #502

merged 1 commit into from
Feb 16, 2023

Conversation

eh2077
Copy link
Contributor

@eh2077 eh2077 commented Feb 15, 2023

Fixed Issues

$ Expensify/App#14668

Tests

  1. Open a chat and send this message 
    # heading
  2. Edit the sent message and verify it's displayed in one line in editing mode
  3. Edit and change the sent message to 
    # heading test
    and save it
  4. Verify the edited header bold text is still displayed in one line

QA

Same as above tests

Video demo

14668-Safari.mov

@eh2077 eh2077 marked this pull request as ready for review February 15, 2023 09:34
@eh2077 eh2077 requested a review from a team as a code owner February 15, 2023 09:34
@melvin-bot melvin-bot bot requested review from MonilBhavsar and removed request for a team February 15, 2023 09:35
@eh2077 eh2077 mentioned this pull request Feb 15, 2023
Closed
6 tasks
@danieldoglas
Copy link
Contributor

@eVoloshchak Can you also test this branch?

@eVoloshchak
Copy link
Contributor

Testing in a couple of hours

eVoloshchak
eVoloshchak approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@eVoloshchak eVoloshchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well!

@danieldoglas danieldoglas merged commit bf099f7 into Expensify:main Feb 16, 2023
@bondydaa bondydaa mentioned this pull request Feb 20, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldoglas danieldoglas danieldoglas approved these changes

@eVoloshchak eVoloshchak eVoloshchak approved these changes

@MonilBhavsar MonilBhavsar Awaiting requested review from MonilBhavsar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eh2077 @danieldoglas @eVoloshchak