Fix/14941 whitespace above block quotes is stripped away #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
dangrous
and removed request for
a team
|
Hi @dangrous this PR is ready for review. Please help me check it. Thank you! |
6 tasks
dangrous
approved these changes
Feb 23, 2023
|
This should be good, just answering some questions before merging |
|
good call, let's not merge yet |
|
@tienifr could you please add screenshots for all platforms? (I'll do the same) |
|
@rushatgabhane Noted. I just added screenshot for all platforms please help to check. Thanks |
rushatgabhane
approved these changes
Feb 24, 2023
|
@dangrous we're good to merge!
@tienifr has answered your questions Expensify/App#14941 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
$ Expensify/App#14941
Tests
For all platforms
1, Compose a message like this:
2, Post the message
3, Edit the message you posted
4, Verify that there is a blank line (and an even amount of space) above and below the block quote. The same message you sent in step 1 is shown in the editor
Additional test for IOS and Android (to ensure there is no regression bug created by the PR)
1, Compose a message like this:
2, Post the message
3, Verify that there is no extra space displayed when used non-quoted and quoted than non-quoted text
QA
For all platforms
1, Compose a message like this:
2, Post the message
3, Edit the message you posted
4, Verify that there is a blank line (and an even amount of space) above and below the block quote. The same message you sent in step 1 is shown in the editor
Additional test for IOS and Android (to ensure there is no regression bug created by the PR)
1, Compose a message like this:
2, Post the message
3, Verify that there is no extra space displayed when used non-quoted and quoted than non-quoted text
Screenshots/Videos
Web
web.mp4
Mobile Web - Chrome
chrome.mp4
Mobile Web - Safari
safari.mp4
Desktop
desktop.mp4
iOS
ios.2.mp4
Android
android.1.mp4